-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache the public keys once generated #11
Comments
We never know when they're going to update the certificates. So there is going to be a 'grey periode'. For example: when someone has stolen the private 🔑 |
Good point. I was only planning to cache it in memory, I think Alamofire does the same but I'm not 100% sure. Not sure if calculating the public key on every request is a performance issue neither. To be examined. |
I have checked the |
The public keys are generated for the domain on every request. but I think we should cache the generated value so that the public key pinning process is optimised.
The text was updated successfully, but these errors were encountered: