Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameters #7

Closed
yannikschaelte opened this issue Aug 1, 2018 · 4 comments
Closed

Fixed parameters #7

yannikschaelte opened this issue Aug 1, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@yannikschaelte
Copy link
Member

Implement fixed parameters, i.e. only a subset of the parameters is to be optimized. This can be handled in amici, but we should also enable this in pesto, probably in the problem, or the objective. One could have fields fixed_par_indices, fixed_par_values. The optimizer should not be aware of this.

@yannikschaelte yannikschaelte added the enhancement New feature or request label Aug 1, 2018
@yannikschaelte yannikschaelte self-assigned this Aug 22, 2018
@yannikschaelte yannikschaelte added the help wanted Extra attention is needed label Aug 30, 2018
@yannikschaelte
Copy link
Member Author

question to all: say we have dim free parameters and dim_full >= dim parameters in total including fixed parameters.

in the return object, we would want to have all in size dim_full, right? then in grad and hess we would insert nans and in x insert the fixed values?

and we would also like lb and ub to be given in dim_full? this would make sense for the visualizations, but the bounds are not strictly required really. also, for user-defined parameter guesses, ones for the fixed parameters would not be required.

@yannikschaelte
Copy link
Member Author

so what I would do would be: in problem fixed parameters and values are specified, and the objective is made capable of handling them. then internally the reduced vector is used, but in the result object everything is in dimension dim_full.

also, in problem.lb and .ub dim_full would be used, possibly extended with nan values.

@yannikschaelte
Copy link
Member Author

is being worked on now in branch feature_fixedpars, see also here: https://github.com/ICB-DCM/pyPESTO/compare/feature_fixedpars?expand=1

@yannikschaelte
Copy link
Member Author

done in pull request #37.

m-philipps pushed a commit that referenced this issue Jun 14, 2022
Allows specifying different conditions in different files.

Closes #7

* Apply suggestions from code review

Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant