Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases #85

Closed
FFroehlich opened this issue Jan 9, 2019 · 8 comments
Closed

Releases #85

FFroehlich opened this issue Jan 9, 2019 · 8 comments
Assignees

Comments

@FFroehlich
Copy link
Contributor

Can we please have releases that tag version that were uploaded to pypi? Without this its pretty difficult to identify which commit pip install pypesto will yield.

@yannikschaelte
Copy link
Member

true. the latest version on the master can be newer than that on pypi, if the version was not updated in the last pull request (e.g. bc it was just a minor thing updated, not qualifying for a new version yet). what exactly do you mean by "releases that tag versions"? can this be done automatically?

@dweindl
Copy link
Member

dweindl commented Jan 10, 2019

Agreed with @FFroehlich .

Whenever a new release is uploaded to pypi, there should also be a github release created. This will create a git tag and save the release on zenodo.

@dweindl
Copy link
Member

dweindl commented Jan 10, 2019

It is true that with the current system there will be multiple versions with the same version number in master. This is not great, but we can live with it. At least one can find the exact commit of the release back from the tag.

To avoid multiple versions with the same version number in master, we change our release process:
All feature pull merge requests go to develop, which is the main line. From there we create release branches which get new version numbers, and only those are merged into master, and nothing else. As nicely illustrated here. This is what we are currently aiming for in https://github.com/ICB-DCM/AMICI .

@yannikschaelte
Copy link
Member

Sounds good. I agree. Should also be documented in https://pypesto.readthedocs.io/en/latest/deploy.html.

@FFroehlich
Copy link
Contributor Author

I would rather set up an automatic deploy script. Should be really straightforward as we dont have any cpp/swig dependencies https://docs.travis-ci.com/user/deployment/pypi/

@dweindl
Copy link
Member

dweindl commented Jan 29, 2019

Will look into

  • Updating contrib guide for github releases
  • Updating contrib guide for auto-closing commits
  • Auto-deploying version-tagged commits

@dweindl dweindl self-assigned this Jan 29, 2019
@dweindl dweindl added this to the Virtual hackathon 1 milestone Jan 29, 2019
@FFroehlich
Copy link
Contributor Author

FFroehlich commented Jan 29, 2019

Auto-deploying version-tagged commits

is already done.

@yannikschaelte
Copy link
Member

The develop branch is now also monitored on readthedocs (https://pypesto.readthedocs.io/en/develop/), so that merges to develop will automatically trigger doc builds. and we will notice doc build failures and can check before releasing.

dweindl added a commit that referenced this issue Feb 4, 2019
m-philipps pushed a commit that referenced this issue Jun 14, 2022
* Use entrypoints to install petablint

* Add ability to specify directory from command line

Also a couple linting things :)
m-philipps pushed a commit that referenced this issue Jun 14, 2022
So far, it was only possible to generate PNGs. This is still the default, but can be changed to any other format supported by matplotlib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants