Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持 script 增加额外的 attributes，比如 crossorigin #276

Closed
maoxiaoke opened this issue Mar 23, 2021 · 3 comments · Fixed by #282
Closed

支持 script 增加额外的 attributes，比如 crossorigin #276

maoxiaoke opened this issue Mar 23, 2021 · 3 comments · Fixed by #282
Labels
discuss supported available in icestark

Comments

@maoxiaoke
Copy link
Collaborator

在一些场景下，需要支持额外的 attributes 比如 crossorigin 等属性
@maoxiaoke
Copy link
Collaborator Author

maoxiaoke commented Mar 23, 2021 •
edited

和 #260 有点关系，看看是不是可以统一起来考虑

maoxiaoke added a commit that referenced this issue Mar 25, 2021
@maoxiaoke
feat: 🎸 support custom script attributes
1d79070 
Closs #276 #260
@maoxiaoke maoxiaoke added the beta has beta version label Mar 25, 2021
@maoxiaoke
Copy link
Collaborator Author

maoxiaoke commented Mar 25, 2021 •
edited

补充：以下 attibute 属性不允许修改

  1. icestark - 内部使用，不允许覆盖
  2. type： text/javascript ，不允许修改
  3. src 不允许修改
  4. async: false，不允许 async，因为可能导致 script 执行错乱

@maoxiaoke maoxiaoke mentioned this issue Apr 8, 2021
Merged
@maoxiaoke maoxiaoke mentioned this issue May 17, 2021
Merged
3 tasks
This was referenced May 25, 2021
Merged
Closed
maoxiaoke added a commit that referenced this issue Jun 11, 2021
@maoxiaoke
feat: script attributes (#282)
5b974aa 
* feat: 🎸 support custom script attributes

Closs #276 #260
@maoxiaoke maoxiaoke added supported available in icestark and removed beta has beta version labels Jun 16, 2021
@maoxiaoke
Copy link
Collaborator Author

supported in v2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss supported available in icestark
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: script attributes ice-lab/icestark
1 participant
@maoxiaoke