feat: script attributes #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hold on, rfc review required. |
ClarkXia
reviewed
Jun 7, 2021
ClarkXia
approved these changes
Jun 9, 2021
SoloJiang
reviewed
Jun 10, 2021
| attrs.forEach(attr => { | ||
| const [attrKey, attrValue] = attr.split('='); | ||
| if (unableReachedAttributes.includes(attrKey)) { | ||
| (isDev ? console.warn : console.log)(formatMessage(`${attrKey} will be ignored by icestark.`)); |
src/util/handleAssets.ts
Outdated
| * script.crossOrigin = 'use-credentials'; | ||
| * sscript.noModule = false; | ||
| */ | ||
| element[builtInScriptAttributesMap.get(attrKey)] = (attrValue === 'true' || attrValue === 'false' || !attrValue) ? !!attrValue : attrValue; |
SoloJiang
approved these changes
Jun 11, 2021
FuzzyFade
reviewed
Jun 11, 2021
src/util/handleAssets.ts
Outdated
| * script.crossOrigin = 'use-credentials'; | ||
| * script.noModule = true; | ||
| */ | ||
| const nonLooseBooleanAttrValue = (attrValue === 'true' || attrValue === 'false') ? Boolean(attrValue) : attrValue; |
There was a problem hiding this comment.
好像可以直接改写成 attrValue === 'true' || attrValue === 'false' || attrValue
因为在该条件下 Boolean(attrValue) 永远返回 true...
src/util/handleAssets.ts
Outdated
| * script.noModule = true; | ||
| */ | ||
| const nonLooseBooleanAttrValue = (attrValue === 'true' || attrValue === 'false') ? Boolean(attrValue) : attrValue; | ||
| element[builtInScriptAttributesMap.get(attrKey)] = nonLooseBooleanAttrValue === undefined ? true : attrValue; |
There was a problem hiding this comment.
|| 的逻辑是前面是 falsy value, 这里只判断 undefined，其他 falsy value 均为有效值
There was a problem hiding this comment.
我的意思是 167 行可以这样写：nonLooseBooleanAttrValue === undefined || attrValue 😄
FuzzyFade
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276