Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 support symbol key for index #316

Merged
merged 5 commits into from
Jun 15, 2021
Merged

feat: 🎸 support symbol key for index #316

merged 5 commits into from
Jun 15, 2021

Conversation

maoxiaoke
Copy link
Collaborator

Closes #298

SoloJiang
SoloJiang reviewed Jun 15, 2021
View reviewed changes
packages/icestark-data/src/event.ts Outdated Show resolved Hide resolved
packages/icestark-data/src/store.ts Outdated Show resolved Hide resolved
@maoxiaoke maoxiaoke requested a review from SoloJiang June 15, 2021 07:09
@maoxiaoke maoxiaoke merged commit dfce854 into release/2.4.0 Jun 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/supportSymbol branch June 15, 2021 08:32
maoxiaoke added a commit that referenced this pull request Jun 16, 2021
@maoxiaoke
Release 2.4.0 (#306)
718199b 
* fix: 🐛 error component render error (#313)

* fix: 🐛 unexpectable sandbox's cleaning up when load module (#311)

* feat: script attributes (#282)

* test: 💍 fix slient pass (#315)

* feat: 🎸 support symbol key for index (#316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoloJiang SoloJiang SoloJiang approved these changes

@ClarkXia ClarkXia Awaiting requested review from ClarkXia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maoxiaoke @SoloJiang