Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 error component render error #313

Merged
merged 2 commits into from
Jun 9, 2021
Merged

fix: 🐛 error component render error #313

merged 2 commits into from
Jun 9, 2021

Conversation

maoxiaoke
Copy link
Collaborator

Closes #312

ClarkXia
ClarkXia requested changes Jun 9, 2021
View reviewed changes
src/AppRouter.tsx Outdated
@@ -207,7 +207,7 @@ export default class AppRouter extends React.Component<AppRouterProps, AppRouter
if (url === ICESTSRK_NOT_FOUND) {
return renderComponent(NotFoundComponent, {});
} else if (url === ICESTSRK_ERROR) {
return renderComponent(ErrorComponent, { err: this.err });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorComponent 默认渲染逻辑修改即可

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@maoxiaoke maoxiaoke requested review from SoloJiang and removed request for FuzzyFade June 9, 2021 12:02
@maoxiaoke maoxiaoke merged commit ae4ce1e into release/2.4.0 Jun 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/omitError branch June 9, 2021 12:03
maoxiaoke added a commit that referenced this pull request Jun 16, 2021
@maoxiaoke
Release 2.4.0 (#306)
718199b 
* fix: 🐛 error component render error (#313)

* fix: 🐛 unexpectable sandbox's cleaning up when load module (#311)

* feat: script attributes (#282)

* test: 💍 fix slient pass (#315)

* feat: 🎸 support symbol key for index (#316)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClarkXia ClarkXia ClarkXia approved these changes

@luhc228 luhc228 Awaiting requested review from luhc228

@SoloJiang SoloJiang Awaiting requested review from SoloJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maoxiaoke @ClarkXia