Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github page takeover doesn't work #18

Closed
swisskyrepo opened this issue Jul 12, 2018 · 2 comments
Closed

Github page takeover doesn't work #18

swisskyrepo opened this issue Jul 12, 2018 · 2 comments

Comments

@swisskyrepo
Copy link

You might need to update the providers.json to detect the Github Page TakeOver at

"cname":["github.io"],

For my case the DNS for the takeover looked like
github.github.io. 1412 IN CNAME sni.github.map.fastly.net.

What do you think about updating it to match the following ?
"cname":["github.io", "fastly.net", "github.com", "github.map"],

Cheers

@Ice3man543
Copy link
Owner

Thanks for notifying. I think the new structure makes sense. I'll update it as soon as I get on a computer :)

@swisskyrepo
Copy link
Author

Fixed in your last commit 13f3fed
Thx :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants