Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test or revert to prior defaults #38

Closed
itaboada opened this issue Mar 4, 2021 · 1 comment
Closed

Fix test or revert to prior defaults #38

itaboada opened this issue Mar 4, 2021 · 1 comment
Labels
question Required for JOSS publication

Comments

@itaboada
Copy link
Collaborator

itaboada commented Mar 4, 2021

Do we fix tests to match the results of the current defaults (SFR evolution MD2014, ICRC 2019 numu diffuse best fit, Planck 2018 cosmological parameters) or revert to prior defaults?
@apizzuto
Copy link
Contributor

apizzuto commented Mar 5, 2021

All of these are fixed in PR #42, so we should be able to close this issue after merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Required for JOSS publication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apizzuto @itaboada