Icon size bug

[torsteingrindvik]

I'm importing bootstrap icons.
I tried the FontForge program to open the TTF file, and found an icon called gears. In the program's editor it looks like this:

So it seems to be perfectly touching the edges of its area.

Using the tab bar example, it gets cut off:

However if I change this line https://github.com/iced-rs/iced_aw/blob/main/src/native/tab_bar.rs#L564
to be:

size: icon_bounds.height * 0.9

I get this:

I don't know enough about fonts and how the rendering in iced works, but hopefully this at least can give an indicator.
Other icons which are made such that the icon touches the "top of their own bounds" were also cut off.

[genusistimelord]

ahh yeah, the font stuff in iced might be making changes soon which can help with this too.

[rctlmk]

There is a horizontal clipping bug as well, but it goes away if the font is changed (even to itself):

// Converted from `.woff2` from the latest release
// https://github.com/twbs/icons/releases/tag/v1.10.3
const BOOTSTRAP_ICONS: iced::Font = iced_native::Font::External {
    name: "Bootstrap-Icons",
    bytes: include_bytes!("../resources/bootstrap-icons.ttf"),
};

fn view(&self) -> iced::Element<'_, Self::Message, iced::Renderer<Self::Theme>> {
    use iced::widget::text;
    use iced_aw::graphics::IconText;
    use iced_aw::ICON_FONT;
    use iced_native::Alignment::Center;

    let gear = '\u{F3E5}';
    let icons = "\u{F159}\u{F156}";

    let content = container(
        column![
            row![text("Icon::Gear"), IconText::new(Icon::Gear).size(40.0),].align_items(Center),
            row![
                text("Icon::Gear, ICON_FONT"),
                IconText::new(Icon::Gear).font(ICON_FONT).size(40.0)
            ]
            .align_items(Center),
            row![
                text("Icon::Gear, bootstrap-icons.ttf"),
                IconText::new(Icon::Gear).font(BOOTSTRAP_ICONS).size(40.0)
            ]
            .align_items(Center),
            row![text("Gear code"), IconText::new(gear).size(40.0)].align_items(Center),
            row![
                text("Gear code, ICON_FONT"),
                IconText::new(gear).font(ICON_FONT).size(40.0)
            ]
            .align_items(Center),
            row![
                text("Hourglass, bootstrap-icons.ttf"),
                IconText::new('\u{F420}').font(BOOTSTRAP_ICONS).size(40.0)
            ]
            .align_items(Center),
            row![
                text("Gear code, bootstrap-icons.ttf"),
                IconText::new(gear).font(BOOTSTRAP_ICONS).size(40.0)
            ]
            .align_items(Center),
            row![text("IconText"), IconText::new(icons).size(40.0)].align_items(Center),
            row![text("IconText, ICON_FONT"), text(icons).font(ICON_FONT).size(40.0)].align_items(Center),
            row![text("text, ICON_FONT"), text(icons).font(ICON_FONT).size(40.0)].align_items(Center),
            row![
                text("IconText, bootstrap-icons.ttf"),
                IconText::new(icons).font(BOOTSTRAP_ICONS).size(40.0)
            ]
            .align_items(Center),
            row![
                text("text, bootstrap-icons.ttf"),
                text(icons).font(BOOTSTRAP_ICONS).size(40.0)
            ]
            .align_items(Center),
        ]
        .spacing(20),
    )
    .padding(10);
}

Here is bootstrap-icons.ttf I was using (it's not a .zip file, change the extension to .ttf): bootstrap-icons.zip
The vertical clipping is still there, though, but it is much less noticeable.
It also seems that the current icons file has other problems and is somewhat outdated.

[genusistimelord]

After investigating I have found that this is 100% a iced issue.

it occurs when the Renderer measures the Text size and returns a incorrect Size.
let (width, height) =
renderer.measure(&self.content, size, self.font.unwrap_or_default(), bounds);

This somehow is not correct and I hope the newer Text renderer will fix this issue.