Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 30 BrowserView issues #255

Closed
icewolfz opened this issue Apr 17, 2024 · 2 comments · Fixed by #260
Closed

Electron 30 BrowserView issues #255

icewolfz opened this issue Apr 17, 2024 · 2 comments · Fixed by #260
Labels
bug Error that needs fixing Requires upstream fix

Comments

@icewolfz
Copy link
Owner

Something in electron 30 was changed and it breaks the entire close and layout systems, i am trying to fix it but so far have not found the reason, so until i can fix it can not update to newer electron, the break is something in how close event fires or how events in general fire.
i cancel the close event because to properly check all clients and open windows have to do awaits and async and it sees electron breaks with async events

@icewolfz icewolfz added the bug Error that needs fixing label Apr 17, 2024
@icewolfz
Copy link
Owner Author

Bug is some how related to executing scripts in a client from the main process, it seems other client's lose webcontents and end up breaking, not sure why they are being destroyed, could be because of the async and it continues to run the close in the background instead of waiting for the await to finish not sure if i can fix it or find a work around yet, it may be due to browserviews being replaced with new webcontentviews, i may re-code the tab system to use them and see if that fixes the issue

@icewolfz icewolfz changed the title Electron 30 issues Electron 30 BrowserView issues Apr 18, 2024
@icewolfz
Copy link
Owner Author

I have a possible fix, after messing with electron fiddle and creating a basic test case i have been able to create a super slim test that breaks the close, i copied it and modified it using the new webContentView that replaces browserView and it worked correctly, so it seems i need to recode the entire mdi system to shift from browserView to webConttentView, see #248 as i already had a issue to work on that. electron 30 just moves it up, when i convert i will close that one and this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error that needs fixing Requires upstream fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant