Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland support #263

Open
icewolfz opened this issue May 21, 2024 · 3 comments
Open

Wayland support #263

icewolfz opened this issue May 21, 2024 · 3 comments
Labels
bug Error that needs fixing linux Applies to linux only build Requires upstream fix

Comments

@icewolfz
Copy link
Owner

Electron has issues with native wayland, some events do not fire, child windows/dialogs may not show but remain hidden in the background, or child/dialog windows may not linked to parent windows thus letting them float or move around when they should not.
Saddly there is not much i can do to fix it at this point i am looking into work a rounds, if i can find a reliable way to detect when native wayland is used in the main process i can try to work around some of the issues. largest that seems to not be able to work around is setting child windows on top of parent windows as some times windows should not allow access to parent windows like the preference window should remain focused until closed right now it will be treated as an entire seperate app and let you continue to use the main client which could cause settings to be corrupted or lost

@icewolfz icewolfz added bug Error that needs fixing linux Applies to linux only build Requires upstream fix labels May 21, 2024
@icewolfz icewolfz pinned this issue May 21, 2024
@icewolfz
Copy link
Owner Author

if(process.env.GDK_BACKEND === 'wayland') can be used to test for wayland once far enough into the main process, beleave it will not be correct until app.ready has been called but anything window related i called after that so this test should work, will need to replace window.once('ready-to-show') with windows.webcontents.once('did-finish-load') as it seems the ready to show is not very good on wayland outside of the main window it seems

this does not fix the on top/parent bug as this will at least show a window but will still not allow a good fix until i can figure out how to fix the parent issue

@icewolfz
Copy link
Owner Author

can test and force wayland using the command line arguments --enable-features=UseOzonePlatform --ozone-platform=wayland

@icewolfz
Copy link
Owner Author

Anther bug related to wayland is window titlebar icon uses the wayland icon and not the jimud icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error that needs fixing linux Applies to linux only build Requires upstream fix
Projects
None yet
Development

No branches or pull requests

1 participant