Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add maestro + platform mappings #18

Merged
merged 23 commits into from
Apr 6, 2020
Merged

add maestro + platform mappings #18

merged 23 commits into from
Apr 6, 2020

Conversation

rosibaj
Copy link
Contributor

@rosibaj rosibaj commented Mar 26, 2020

v1 of example mappings

  • file_centric for maestro
  • file_centric for the platform (file + clinical data)

@rosibaj rosibaj requested a review from blabadi March 26, 2020 00:50
@rosibaj
Copy link
Contributor Author

rosibaj commented Mar 26, 2020

@blabadi I added for both mappings as:

  • the settings maestro previously had
  • the file_autocomplete fields
  • s to mapping ( i think it has to be that way? )

@rosibaj rosibaj requested a review from blabadi March 26, 2020 04:15
junjun-zhang
junjun-zhang reviewed Mar 30, 2020
View reviewed changes
mappings/maestro_file_centric.json Outdated Show resolved Hide resolved
mappings/maestro_file_centric.json Outdated Show resolved Hide resolved
mappings/maestro_file_centric.json Show resolved Hide resolved
mappings/maestro_file_centric.json Show resolved Hide resolved
mappings/maestro_file_centric.json Show resolved Hide resolved
mappings/maestro_file_centric.json Show resolved Hide resolved
mappings/platform_file_centric.json Show resolved Hide resolved
mappings/platform_file_centric.json Show resolved Hide resolved
mappings/platform_file_centric.json Outdated Show resolved Hide resolved
mappings/platform_file_centric.json Show resolved Hide resolved
@blabadi
Copy link
Contributor

blabadi commented Apr 6, 2020

one last thing to skim through is what fields we may missed in auto complete

@rosibaj
Copy link
Contributor Author

rosibaj commented Apr 6, 2020

@junjun-zhang I believe you reviewed the fields added to autocomplete? Did you see any missing?

@rosibaj rosibaj requested a review from blabadi April 6, 2020 18:52
@blabadi
Copy link
Contributor

blabadi commented Apr 6, 2020

use squash and merge please, there is alot of commits here !

@rosibaj rosibaj merged commit fefa342 into master Apr 6, 2020
@blabadi blabadi deleted the add_es_mappings branch April 7, 2020 00:43
@rosibaj rosibaj mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junjun-zhang junjun-zhang junjun-zhang approved these changes

@blabadi blabadi blabadi approved these changes

@christinayung christinayung Awaiting requested review from christinayung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rosibaj @blabadi @junjun-zhang @christinayung