-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI]: Application Section C: Add a Collaborator Modal & Validation #20
Comments
* add Collaborator section * add collab section ui * add collaborators modal form * add form validation schema * styling * add placeholder * fix bad rebase * updade form handling props * Update components/pages/Applications/ApplicationForm/Forms/Collaborators.tsx Co-authored-by: Anders Richardsson <2107110+caravinci@users.noreply.github.com> Co-authored-by: Anders Richardsson <2107110+caravinci@users.noreply.github.com>
@rosibaj static UI is up in dev. QA momentarily. Had a chat with @caravinci and we'll need to break the validation of this into a separate ticket as it doesn't quite fit in with how we're currently processing |
@ciaranschutte will do, breakign out ticket now. |
@ciaranschutte just some preliminary UI feedback in case you want to fix before moving.
|
@ciaranschutte @caravinci Remaining work abstracted to #174 |
Goal: To build Section C: Add/Edit a collaborator modal with working local validation.
Zeplin links:
Blank Modal: https://zpl.io/VDggJG3
Form with errors: https://zpl.io/V4NNpZ4
Valid form: https://zpl.io/bARRJwp
Note: Justin has made a lot of these fields and validations work in section A and B, please reuse what you can.
Expected Outcomes
- [ ] 5. If the applicant choosesNote: moved to follow-up ticketAuthorized Personnel
then showPosition Title
field as the last field. If the applicant choosesAuthorized Student
then showPursuing Degree
field as the last field. This defaults to showingPosition Title
field.- [ ] 6. Button is disabled until the applicant fills in the form correctlyNote: moved to follow-up ticketLocal Validation See errors in https://zpl.io/V4NNpZ4
- [ ] 8. On top of required, the email field needs to be in a valid email formatNote: moved to follow-up ticketNote: the functionality for the "Primary Affiliation must be the same as the Applicant" will come later when application can be saved [Data Hookup]: Global validation for primary affiliation #54
Correctly filled out form: https://zpl.io/bARRJwp
- [ ] 9. Once the form has valid entries, the "Add Collaborator" button is enabled.Note: moved to follow-up ticketThe text was updated successfully, but these errors were encountered: