Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: Application Section C: Add a Collaborator Modal & Validation #20

Closed
5 tasks done
kcullion opened this issue May 5, 2021 · 5 comments
Closed
5 tasks done
Assignees
Labels

Comments

@kcullion
Copy link

kcullion commented May 5, 2021

Goal: To build Section C: Add/Edit a collaborator modal with working local validation.

Zeplin links:
Blank Modal: https://zpl.io/VDggJG3
Form with errors: https://zpl.io/V4NNpZ4
Valid form: https://zpl.io/bARRJwp

Note: Justin has made a lot of these fields and validations work in section A and B, please reuse what you can.

Expected Outcomes

  • 1. Set up modal with Instructions
  • 2. Set up form using components in ARGO component library.
  • 3. Some form elements have blue notes beside them
  • 4. Some form elements have placeholder text to show examples of what to fill out in the field
    - [ ] 5. If the applicant chooses Authorized Personnel then show Position Title field as the last field. If the applicant chooses Authorized Student then show Pursuing Degree field as the last field. This defaults to showing Position Title field. Note: moved to follow-up ticket
    - [ ] 6. Button is disabled until the applicant fills in the form correctly Note: moved to follow-up ticket

Local Validation See errors in https://zpl.io/V4NNpZ4

  • 7. All fields marked with * are required.
    - [ ] 8. On top of required, the email field needs to be in a valid email format Note: moved to follow-up ticket
    Note: the functionality for the "Primary Affiliation must be the same as the Applicant" will come later when application can be saved [Data Hookup]: Global validation for primary affiliation #54

Correctly filled out form: https://zpl.io/bARRJwp
- [ ] 9. Once the form has valid entries, the "Add Collaborator" button is enabled. Note: moved to follow-up ticket

image

image

image

@rosibaj rosibaj added this to the [FUTURE] Donkey Kong Sprint 51 milestone Jun 2, 2021
@kcullion kcullion changed the title [UI]: Application Section C: Add/Edit a Collaborator Modal & Validation [UI]: Application Section C: Add a Collaborator Modal & Validation Jun 17, 2021
ciaranschutte added a commit that referenced this issue Jun 28, 2021
* add Collaborator section

* add collab section ui

* add collaborators modal form

* add form validation schema

* styling

* add placeholder

* fix bad rebase

* updade form handling props

* Update components/pages/Applications/ApplicationForm/Forms/Collaborators.tsx

Co-authored-by: Anders Richardsson <2107110+caravinci@users.noreply.github.com>

Co-authored-by: Anders Richardsson <2107110+caravinci@users.noreply.github.com>
@ciaranschutte
Copy link
Contributor

@rosibaj static UI is up in dev. QA momentarily. Had a chat with @caravinci and we'll need to break the validation of this into a separate ticket as it doesn't quite fit in with how we're currently processing

@rosibaj
Copy link
Contributor

rosibaj commented Jun 30, 2021

@ciaranschutte will do, breakign out ticket now.

@kcullion
Copy link
Author

kcullion commented Jun 30, 2021

@ciaranschutte just some preliminary UI feedback in case you want to fix before moving.
see zeplin for correct blue notes: https://zpl.io/VDggJG3

  • Fix blue notes
  • And Position Title should be required
  • The radio buttons aren't selecting?

image

@rosibaj
Copy link
Contributor

rosibaj commented Jun 30, 2021

@ciaranschutte @caravinci Remaining work abstracted to #174

@rosibaj
Copy link
Contributor

rosibaj commented Jun 30, 2021

@kcullion i will move your comment to #174

@rosibaj rosibaj closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants