Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Hookup + UI] Set up toasts #414

Closed
6 tasks
kcullion opened this issue Sep 2, 2021 · 10 comments
Closed
6 tasks

[Data Hookup + UI] Set up toasts #414

kcullion opened this issue Sep 2, 2021 · 10 comments
Assignees
Labels

Comments

@kcullion
Copy link

kcullion commented Sep 2, 2021

Once infrastructure is ready: #27
Note: these should behave like the ones on Platform, where they are dismissible but also disappear after a short time.

Success toasts:

  • After an application is APPROVED, and the applicant adds a new collaborator, show this toast: https://zpl.io/25medXQ
    image

  • After an application is APPROVED, and the applicant removes a collaborator, show this toast: https://zpl.io/aXqGg78
    image

  • After an application is APPROVED, and the applicant uploads a new ethics letter, show this toast: https://zpl.io/25medmr
    image

@rosibaj for these first three, I think we just need to show them when an application is approved because that's when an email gets sent out. Do you think we should also do the general toast (i.e. just the titles of these ones) for before an application is approved (similar to the next toast for closed before approval)?

Failure toast

  • If something goes wrong with a user action and they should try again, show this toast: https://zpl.io/boEYORk
    image
@ciaranschutte
Copy link
Contributor

@kcullion for the error toast... do you mean any user action across the entire project?

@kcullion
Copy link
Author

kcullion commented Sep 27, 2021

@ciaranschutte I guess maybe if an error occurred at any point when logged in, your error page shows right? So perhaps we don't need this toast? I'm not sure what other types of errors could occur - do you know?

@ciaranschutte
Copy link
Contributor

@kcullion @rosibaj my thoughts...
So the error something went wrong generic page should only be used if user navigates somewhere they shouldn't

This error toast should pop up for any user interaction ie. upload, adding, deleting, modifying. Pretty much every case that isn't navigation.

Does this sound ok ?

@kcullion
Copy link
Author

@ciaranschutte we already have errors on upload - like what you did with the file is too large.

Do you mean then, if there's an unknown error when the user does any action then this toast will pop up? i.e. we don't have to identify every scenario where they could get a user error?

@kcullion
Copy link
Author

As discussed with @rosibaj and @ciaranschutte on slack, if we have an API call that fails due to timeout, network failure, etc, after a click or a save id - then show the error toast

ciaranschutte added a commit that referenced this issue Oct 15, 2021
* add toasts for succss on add and remove collaborator

* add toasts to closing applications

* add toasts to collaborators

* ethics letter upload toast

* toaster error on fetch errors outside 2xx range

* remove console log

* remove flash message

* remove unused import

* move ModalStates to const file

* revert deleted success message
This was referenced Oct 18, 2021
@kcullion
Copy link
Author

kcullion commented Oct 19, 2021

@ciaranschutte checked this in QA and I'm sorry, I should have updated this ticket with what we talked about on slack with Ann. All toasts look great, except - can you remove this one.

  • close after approval.
    We decided this should be a banner instead and Ann implemented that
    image

Also - am I able to test the failure toasts?
As discussed with @rosibaj and @ciaranschutte on slack, if we have an API call that fails due to timeout, network failure, etc, after a click or a save id - then show the error toast

@akachru-github akachru-github modified the milestones: DACO Application - Sprint 5, DACO Sprint 6, DACO Sprint 6 - Kannbanne Oct 21, 2021
@kcullion kcullion added this to the DACO Application - Kannbanne milestone Oct 27, 2021
@ciaranschutte
Copy link
Contributor

#522

@ciaranschutte
Copy link
Contributor

@kcullion figuring out the best way to test errors toasts. will message you later.

ciaranschutte added a commit that referenced this issue Oct 27, 2021
* remove toast.

* remove unused imports
@kcullion
Copy link
Author

kcullion commented Nov 3, 2021

Tested in QA and confirmed that I just get the "Closed after approval" banner and not the toast now. Thanks @ciaranschutte !

@kcullion
Copy link
Author

toasts are working in staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants