-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Hookup + UI] Set up toasts #414
Comments
@kcullion for the error toast... do you mean any user action across the entire project? |
@ciaranschutte I guess maybe if an error occurred at any point when logged in, your error page shows right? So perhaps we don't need this toast? I'm not sure what other types of errors could occur - do you know? |
@kcullion @rosibaj my thoughts... This error toast should pop up for any user interaction ie. upload, adding, deleting, modifying. Pretty much every case that isn't navigation. Does this sound ok ? |
@ciaranschutte we already have errors on upload - like what you did with the file is too large. Do you mean then, if there's an unknown error when the user does any action then this toast will pop up? i.e. we don't have to identify every scenario where they could get a user error? |
As discussed with @rosibaj and @ciaranschutte on slack, if we have an API call that fails due to timeout, network failure, etc, after a click or a save id - then show the error toast |
* add toasts for succss on add and remove collaborator * add toasts to closing applications * add toasts to collaborators * ethics letter upload toast * toaster error on fetch errors outside 2xx range * remove console log * remove flash message * remove unused import * move ModalStates to const file * revert deleted success message
@ciaranschutte checked this in QA and I'm sorry, I should have updated this ticket with what we talked about on slack with Ann. All toasts look great, except - can you remove this one. Also - am I able to test the failure toasts? |
@kcullion figuring out the best way to test errors toasts. will message you later. |
Tested in QA and confirmed that I just get the "Closed after approval" banner and not the toast now. Thanks @ciaranschutte ! |
toasts are working in staging |
Once infrastructure is ready: #27
Note: these should behave like the ones on Platform, where they are dismissible but also disappear after a short time.
Success toasts:
After an application is
APPROVED
, and the applicant adds a new collaborator, show this toast: https://zpl.io/25medXQAfter an application is
APPROVED
, and the applicant removes a collaborator, show this toast: https://zpl.io/aXqGg78After an application is
APPROVED
, and the applicant uploads a new ethics letter, show this toast: https://zpl.io/25medmr@rosibaj for these first three, I think we just need to show them when an application is approved because that's when an email gets sent out. Do you think we should also do the general toast (i.e. just the titles of these ones) for before an application is approved (similar to the next toast for closed before approval)?
When an application is closed before
APPROVED
, so the user clicks on this confirmation button: https://zpl.io/2Gqj8xdShow the following toast: https://zpl.io/bAKRgMn
When the application is closed after
APPROVED
, so the user (applicant or DACO admin) clicks on this confirmation button: https://zpl.io/V1AxxQJShow this toast: https://zpl.io/V4G6OG8
Failure toast
The text was updated successfully, but these errors were encountered: