OpenSslSession#initPeerCerts creates too long almost empty arrays.

Motivation: netty#5945 (comment) Modifications: Added volatile for correct initialization of actual certificates: netty#5945 (comment) Result: Concurrency issue fixed
ichaki5748 · Oct 31, 2016 · 7964d89 · 7964d89
1 parent b2379e6
commit 7964d89
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslJavaxX509Certificate.java
@@ -30,7 +30,7 @@
 
 final class OpenSslJavaxX509Certificate extends X509Certificate {
     private final byte[] bytes;
-    private X509Certificate wrapped;
+    private volatile X509Certificate wrapped;
 
     public OpenSslJavaxX509Certificate(byte[] bytes) {
         this.bytes = bytes;

diff --git a/handler/src/main/java/io/netty/handler/ssl/OpenSslX509Certificate.java b/handler/src/main/java/io/netty/handler/ssl/OpenSslX509Certificate.java
@@ -34,7 +34,7 @@
 final class OpenSslX509Certificate extends X509Certificate {
 
     private final byte[] bytes;
-    private X509Certificate wrapped;
+    private volatile X509Certificate wrapped;
 
     public OpenSslX509Certificate(byte[] bytes) {
         this.bytes = bytes;