-
-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSslSession#initPeerCerts creates too long almost empty arrays #5945
Comments
Maybe want to provide a PR with a fix?
|
Yes, sure, will try to do it this week |
Thx
|
Also |
@iainmcgin please open separate PRs for the separate issues and ping me once you are ready. I will review then |
You probably meant to reference @ichaki5748 |
@iainmcgin ups yes... sorry I need more ☕️ |
Motivation: netty#5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
Motivation: netty#5945 (comment) Modifications: Added volatile for correct initialization of actual certificates: netty#5945 (comment) Result: Concurrency issue fixed
@normanmaurer Hi, please see #5967 #5966 |
Motivation: netty#5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
Motivation: #5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
Motivation: #5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
Fixed by #5967 |
Motivation: netty#5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
Motivation: netty#5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
netty 4.1.6
io.netty.handler.ssl.ReferenceCountedOpenSslEngine.OpenSslSession#initPeerCerts
But should probably be
int len = chain.length + 1; // <------ so we have first entry as client cert + chain.length
The text was updated successfully, but these errors were encountered: