-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement kvitems in the C extension for increased performance. #21
Comments
This implementation follows the same logic of the python kvitems function, reusing the builder_t object used by the items function. Performance wise, kvitems is slightly faster than items, which is what we expected in the first place. This commit provides a first implementation for #21. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
@ltalirz could you check this one? As expected I'm getting about ~4x improvement on I also sped up a bit the python implementation of |
Hi @rtobar - thanks a lot for your efforts! A few observations:
|
@ltalirz oops, bad reference counting there... I just pushed some further fixes to the |
Thanks - I'm now at 13s (0.01ms/pair), memory issues seem gone. Looking great! |
Code merged to the |
Currently the new
kvitems
method is implemented in python, which is what all backends use. The C backend however should see performance benefits by seeing this method implemented in C, with an expected increase of something around ~3x, 4x, depending on the use case.See #18 (comment) and #18 (comment) for reference.
The text was updated successfully, but these errors were encountered: