Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple_values support to Python backend #9

Closed
jpmckinney opened this issue Sep 14, 2019 · 3 comments
Closed

Add multiple_values support to Python backend #9

jpmckinney opened this issue Sep 14, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@jpmckinney
Copy link

No description provided.

@rtobar rtobar added the enhancement New feature or request label Sep 15, 2019
@rtobar
Copy link

rtobar commented Sep 15, 2019

Yes, I realised about this when fixing the support for multiple values in the C backend.

For reference, the yajl backend (based on yajl 1) also doesn't offer the flag, and it always supports multiple values (i.e., it doesn't throw errors when presented with multiple values). This apparently was a limitation of yajl 1.x, but I wouldn't worry about it as the backend has been advertised as deprecated for years.

The python backend indeed also doesn't offer the flag, and by default it doesn't support multiple values. This is what would have to be implemented.

rtobar added a commit that referenced this issue Sep 15, 2019
@rtobar
Adding multiple_values support to python backend
54c3c26 
This addresses #9. When multiple_values is set we continue iterating
over the lexer and the parse_value routine until they run out of values.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
@rtobar
Copy link

rtobar commented Sep 15, 2019

OK, this is implemented now on the master branch. I'm leaving this open for you to close after confirming this is working as expected.

@jpmckinney
Copy link
Author

Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @rtobar