Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3-related fixes to ngamsUtils/ngamsUtils/ngasVerifyCloning.py #94

Closed
ulange-eso-org opened this issue Jun 30, 2022 · 1 comment
Closed

Python3-related fixes to ngamsUtils/ngamsUtils/ngasVerifyCloning.py #94

ulange-eso-org opened this issue Jun 30, 2022 · 1 comment

Comments

@ulange-eso-org
Copy link
Contributor 

--- a/src/ngamsUtils/ngamsUtils/ngasVerifyCloning.py
+++ b/src/ngamsUtils/ngamsUtils/ngasVerifyCloning.py
@@ -321,7 +321,7 @@ def main():
                                     "CLONE_VER_REP_{:s}".format(source_disk_id))
     except Exception as e:
         print("ERROR occurred executing the Clone Verification Tool: \n\n" + str(e) + "\n")
-        print(traceback.print_exc())
+        traceback.print_exc()
         sys.exit(1)
rtobar added a commit that referenced this issue Jul 10, 2022
@rtobar
Avoid printing None
762cc02 
The traceback.print_exc function does printing internally, and thus
there's no need to print its result (which is None).

This was pointed out in #93 and #94.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
@rtobar
Copy link
Contributor

rtobar commented Nov 1, 2022

This was fixed and merged into master some time ago, closing.

@rtobar rtobar closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtobar @ulange-eso-org