VB -> C#: Duplicate Namespace

[vfle]

Please prefix the issue title with either "C# -> VB: " or "VB -> C#: " if relevant

Input code

Namespace Child

Erroneous output

namespace Root.Namespace.Root.Namespace.Child

Expected output

namespace Root.Namespace.Child

Details

Product in use: VS extension

Version in use: 6.1

The project is a class library with a root namespace project property set. At the example above it would be Root.Namespace .
I am not sure why the second root namespace appears.

It is an easy work around on the produced code to replace the duplicates, just reporting in case something more serious is hidden.

[GrahamTheCoder]

Thanks for the report. QualifyNode covers the general case of qualification. I suspect that means this special case code is actually redundant, and causing this bug by doing it again:
https://github.com/icsharpcode/CodeConverter/blob/master/ICSharpCode.CodeConverter/CSharp/NodesVisitor.cs#L106

I think the tests don't have a root namespace set, so it's hard to notice it during development and will need a slightly custom test (or a restoration of the project and solution level tests which could easily set a root namespace).

[knodel12]

@GrahamTheCoder Wondering why you removed the RootNamespace logic. It seems that all VB files that previously had no namespace now get created in C# without a namespace, regardless of the project root namespace. Is this intentional?

[GrahamTheCoder]

Ah ok yes, thanks for paying attention! In the case where the namespace is missing, we do indeed still need to add it, but we don't need to add on to existing ones. I'll add that bit back.

[GrahamTheCoder]

I've also tried to tighten up the addition of the root namespace where relevant. Shout if you notice any more issues with it.

[GrahamTheCoder]

See repro on #318 (closed to consolidate with this)

[GrahamTheCoder]

Fixed in 2483369