Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MainWindow.OpenLink for net6.0 #2585

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

yyjdelete
Copy link
Contributor

No description provided.

@siegfriedpammer
Copy link
Member

siegfriedpammer commented Dec 26, 2021

Would you mind explaining why this change is necessary? I didn't yet have a closer look at the changes required to get ILSpy working with net6.0 (only net5.0 as mentioned in #2324, but the changes mentioned there are still necessary for net6.0), hence the question. Thanks!

@yyjdelete
Copy link
Contributor Author

It's a broken change from .NET Framework to .NET Core, and UseShellExecute=true is required to open URL with browser in windows.
https://docs.microsoft.com/en-us/dotnet/core/compatibility/fx-core#change-in-default-value-of-useshellexecute
ProcessStartInfo.UseShellExecute has a default value of false on .NET Core. On .NET Framework, its default value is true.

And the same change is already in AvalonEdit.
icsharpcode/AvalonEdit@9ca474a

@siegfriedpammer
Copy link
Member

Thank you for the explanation!

@siegfriedpammer siegfriedpammer merged commit 88e2f5e into icsharpcode:master Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants