-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undesirable Console log while reading #807
Comments
Yeah, that was never supposed to be committed. Sorry about that. I'll try to release a new version fairly soon with this removed. |
Dear Piksel, thank you very much for answering this fast and for correcting this issue. |
Dear Piksel, when are you going to put a new version with the fix online? :) |
@PalfLex There were some concurrency bugs when testing in CI, so I put the new release on hold until I could isolate the cause. I have not been able to reproduce the problems since then, so I am leaning towards ignoring it for now anyway. Sorry for the delay. |
Steps to reproduce
Expected behavior
This method should not write information ("Input Encoding:" and "Input Bytes") into the console.
Actual behavior
Since the new version 1.4.1 (Commit: a389d9f; "fix(zip): cleanup/fix of StringCodec") there those two lines of code (line 577 and 597 in ZipInputStream) which always write into the console log.
Could you please fix this, or add an variable to disable this console log?
Thanks
Version of SharpZipLib
Current Version: 1.4.1
Obtained from (only keep the relevant lines)
The text was updated successfully, but these errors were encountered: