Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undesirable Console log while reading #807

Closed
PalfLex opened this issue Dec 14, 2022 · 4 comments · Fixed by #809
Closed

Undesirable Console log while reading #807

PalfLex opened this issue Dec 14, 2022 · 4 comments · Fixed by #809

Comments

@PalfLex
Copy link

PalfLex commented Dec 14, 2022

Steps to reproduce

  1. It happens every time when the InitialRead method is called.

Expected behavior

This method should not write information ("Input Encoding:" and "Input Bytes") into the console.

Actual behavior

Since the new version 1.4.1 (Commit: a389d9f; "fix(zip): cleanup/fix of StringCodec") there those two lines of code (line 577 and 597 in ZipInputStream) which always write into the console log.

Could you please fix this, or add an variable to disable this console log?

Thanks

Version of SharpZipLib

Current Version: 1.4.1

Obtained from (only keep the relevant lines)

  • Package installed using NuGet
@piksel
Copy link
Member

piksel commented Dec 14, 2022

Yeah, that was never supposed to be committed. Sorry about that. I'll try to release a new version fairly soon with this removed.

@PalfLex
Copy link
Author

PalfLex commented Dec 15, 2022

Dear Piksel, thank you very much for answering this fast and for correcting this issue.

@PalfLex
Copy link
Author

PalfLex commented Jan 4, 2023

Dear Piksel, when are you going to put a new version with the fix online? :)

@piksel
Copy link
Member

piksel commented Jan 4, 2023

@PalfLex There were some concurrency bugs when testing in CI, so I put the new release on hold until I could isolate the cause. I have not been able to reproduce the problems since then, so I am leaning towards ignoring it for now anyway. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants