Change hands configuration files #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xEnVrE
suggested changes
Sep 11, 2023
There was a problem hiding this comment.
Thanks @Nicogene, I am requesting changes as some of the numbers are not correct as per the documentation.
Important
The limits for the new hand in the CSV are not updated as per the documentation.
This was referenced Sep 11, 2023
Nicogene
force-pushed
the
refactorMK5Coupling
branch
from
d131291
to
316f43b
Compare
|
@xEnVrE I updated the limits for the hand mk5.1 also in the csv/urdf and I corrected the coupling params as done here: icub-tech-iit/documentation#312 I think we can safely merge |
xEnVrE
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires robotology/gazebo-yarp-plugins#662
cc @xEnVrE