Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waist_imu in urdf file #99

Merged
merged 7 commits into from
May 5, 2023

Conversation

martinaxgloria
Copy link
Member

As per title. WIP

@mfussi66
Copy link
Member

Thanks @martinaxgloria ! Could you add in the PR post a test in the simulator?

@pattacini pattacini requested review from mfussi66 and removed request for pattacini April 28, 2023 09:59
@martinaxgloria martinaxgloria removed the request for review from Nicogene April 28, 2023 12:40
Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made on the urdf have been done by hand or it is the result of the generation from simmechanics_to_urdf?

Checking the CI the generation of the urdf fails because XSENS_MTI_630_IMU_CSYS does not exist in the simmechanics xml, since we decided to not update for now the simulation model with the creo 9->7 procedure.

The only idea I have is to refer to the torso_1 csys and use

additionalTransformation -> https://github.com/robotology/icub-models-generator/blob/fd2d430a399119f2ded5a15f1c8ea4185b9aca6c/simmechanics/CMakeLists.txt#L279

for getting the correct orientation.

@traversaro is there a better way to add a frame that does not exist in the xml?

@martinaxgloria
Copy link
Member Author

The changes made on the urdf have been done by hand or it is the result of the generation from simmechanics_to_urdf?

I did it by hand.

@traversaro
Copy link
Member

traversaro commented May 2, 2023

@traversaro is there a better way to add a frame that does not exist in the xml?

In the past we just used XMLBlobs : https://github.com/robotology/icub-models-generator/blob/fd2d430a399119f2ded5a15f1c8ea4185b9aca6c/simmechanics/data/icub3/ICUB_3_all_options.yaml#L545 .

@martinaxgloria
Copy link
Member Author

I added the sensorBlob for waist_imu here: https://github.com/icub-tech-iit/ergocub-software/pull/99/files#diff-d43fa5cafdc7096f7b13d331fdfa24223268f048fc00d8c05648fa95e7a3832b

@traversaro is this what you were referring to?

@martinaxgloria
Copy link
Member Author

Here 47900b1 I added the XMLBlobs as suggested. Moreover, I restore the urdf file, so that it is not modified by hand anymore, and I update the mass and inertia properties in the .yaml file

@Nicogene

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now seems ok!

@Nicogene Nicogene merged commit dbd3190 into icub-tech-iit:master May 5, 2023
1 check passed
@Nicogene
Copy link
Member

Nicogene commented May 5, 2023

I squashed the commit in order to be easily reversible (see #106)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants