Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Optimization steps not printed #218

Closed
10 tasks
mgarrouste opened this issue Oct 17, 2022 · 6 comments
Closed
10 tasks

[DEFECT] Optimization steps not printed #218

mgarrouste opened this issue Oct 17, 2022 · 6 comments
Labels
defect Something isn't working

Comments

@mgarrouste
Copy link


Defect Description

Describe the defect

What did you expect to see happen?

The opt_soln_0.csv should contain all the steps of the optimization

What did you see instead?

The opt_soln.png shows that the optimization has converged but the opt_soln_0.csv only shows a subset of the steps performed.

Do you have a suggested fix for the development team?

Describe how to Reproduce
Steps to reproduce the behavior:

  1. run HERON case with input file provided

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
    Archive.zip
@mgarrouste mgarrouste added the defect Something isn't working label Oct 17, 2022
@dylanjm
Copy link
Collaborator

dylanjm commented Oct 17, 2022

@mgarrouste can you update your attached archive to include everything required to run the case please? Things like the arma.pk and any custom functions required. This will allow me to run your case fully. Thanks.

@mgarrouste
Copy link
Author

@mgarrouste
Copy link
Author

This is still an issue and I will need to run HERON models very soon

@mgarrouste
Copy link
Author

HERON_issue.zip
Here are the necessary files to run my case and the opt_soln_0.csv and opt_path.png when I run it on the HPC. The png file shows at least 3 steps while only the first one is printed to the csv file

@mgarrouste
Copy link
Author

Re-ran the case with persistence=7 instead of =3 and got these results: one more step is printed to the csv file so it seems like the issue is that the final result is not printed to the csv file
opt_soln_0-2.csv
opt_path-2

@dylanjm
Copy link
Collaborator

dylanjm commented Dec 15, 2022

This issue should be solved by #241

@dylanjm dylanjm closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants