Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Update Dispatch Plotting Capabilities #261

Closed
10 tasks done
yangx789 opened this issue Feb 15, 2023 · 1 comment · Fixed by #260
Closed
10 tasks done

[TASK] Update Dispatch Plotting Capabilities #261

yangx789 opened this issue Feb 15, 2023 · 1 comment · Fixed by #260
Labels
task Feature requests

Comments

@yangx789
Copy link
Contributor

yangx789 commented Feb 15, 2023 •
edited by PaulTalbot-INL
Loading

Edited the dispatch plot script under HERON and changed it's output visualization from line plots to stackplots.
Created a pull request to address this issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@yangx789 yangx789 added the task Feature requests label Feb 15, 2023
@yangx789 yangx789 mentioned this issue Feb 15, 2023
Merged
@dylanjm dylanjm changed the title [TASK] Edited the dispatch plot script under HERON with visualization [TASK] Update Dispatch Plotting Capabilities Feb 15, 2023
@PaulTalbot-INL PaulTalbot-INL linked a pull request Mar 1, 2023 that will close this issue
Edited dispatch plot with visualization #260
Merged
@PaulTalbot-INL
Copy link
Collaborator

Approved to close via #260.

@dylanjm dylanjm mentioned this issue May 25, 2023
Merged
9 tasks
@yangx789 yangx789 mentioned this issue Jun 9, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Edited dispatch plot with visualization
2 participants
@PaulTalbot-INL @yangx789