Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oauth.ts from Services to User Management #150

Closed
kalebhouck opened this issue Feb 18, 2021 · 0 comments · Fixed by #170
Closed

Move oauth.ts from Services to User Management #150

kalebhouck opened this issue Feb 18, 2021 · 0 comments · Fixed by #170
Labels
good first issue Good for newcomers

Comments

@kalebhouck
Copy link
Collaborator

kalebhouck commented Feb 18, 2021

Reason

For clarity and better code organization.

Design

Consolidate authentication code in one spot. Move oauth.ts from Service package to User Management package.

Impact

Minimal impact

@DnOberon DnOberon added the good first issue Good for newcomers label Feb 18, 2021
@jerenmb jerenmb linked a pull request Mar 11, 2021 that will close this issue
33 tasks
DnOberon pushed a commit that referenced this issue Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants