Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we get a devel to master merge? #25

Closed
dschwen opened this issue Jan 30, 2016 · 4 comments
Closed

Can we get a devel to master merge? #25

dschwen opened this issue Jan 30, 2016 · 4 comments
Assignees
@brianmoose

Comments

@dschwen
Copy link
Member

dschwen commented Jan 30, 2016

Pleeeeease :-)
@brianmoose
Copy link

So you want to ignore the failing test and thus have master be broken?
Or is the test core dumping because I didn't build it correctly?

@dschwen
Copy link
Member Author

dschwen commented Feb 1, 2016

Wait, what? Which test is failing? Let me check.

@dschwen
Copy link
Member Author

dschwen commented Feb 1, 2016

Ugh, that SPPARKS stuff is borked. Valgrind show a ton of errors. The tests succeeds cleanly on a few systems we tried. But obviously something is wrong.

@dschwen dschwen mentioned this issue Feb 1, 2016
Closed
@brianmoose
Copy link

I invalidated it and it passed this time. So it is has now been merged.

@dschwen dschwen mentioned this issue Feb 1, 2016
Merged
@dschwen dschwen closed this as completed Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianmoose brianmoose

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dschwen @brianmoose