Remove preset BC objects and legacy dirichlet BC param

refs #17316

examples/ex01_inputfile/src/base/ExampleApp.C

@@ -20,10 +20,6 @@ validParams<ExampleApp>()
 
   params.set<bool>("automatic_automatic_scaling") = false;
 
-  // Sets DirichletBC default for preset = true
-  // This will be removed in the future when the global default is changed
-  params.set<bool>("use_legacy_dirichlet_bc") = false;
-
   return params;
 }
 

examples/ex15_actions/src/base/ExampleApp.C

@@ -21,10 +21,6 @@ validParams<ExampleApp>()
 
   params.set<bool>("automatic_automatic_scaling") = false;
 
-  // Sets DirichletBC default for preset = true
-  // This will be removed in the future when the global default is changed
-  params.set<bool>("use_legacy_dirichlet_bc") = false;
-
   return params;
 }
 

framework/doc/content/source/bcs/ADDirichletBC.md

@@ -35,10 +35,6 @@ before the solve begins. With `preset = false`, the boundary condition is
 only enforced as the solve progresses. In most situations, presetting the boundary
 condition is better.
 
-The default behavior of the `preset` parameter is determined by the flag
-`use_legacy_dirichlet_bc` in the application. Change this flag to false to switch
-your application to the preferred behavior (setting `preset = true` as the default).
-
 ## Example Input Syntax
 
 !listing test/tests/bcs/ad_bc_preset_nodal/bc_preset_nodal.i block=BCs

framework/doc/content/source/bcs/ADFunctionDirichletBC.md

@@ -37,10 +37,6 @@ before the solve begins. With `preset = false`, the boundary condition is
 only enforced as the solve progresses. In most situations, presetting the boundary
 condition is better.
 
-The default behavior of the `preset` parameter is determined by the flag
-`use_legacy_dirichlet_bc` in the application. Change this flag to false to switch
-your application to the preferred behavior (setting `preset = true` as the default).
-
 ## Example Input Syntax
 
 !listing test/tests/bcs/ad_bcs/ad_bc.i block=BCs

framework/doc/content/source/bcs/DirichletBC.md

@@ -33,10 +33,6 @@ before the solve begins. With `preset = false`, the boundary condition is
 only enforced as the solve progresses. In most situations, presetting the boundary
 condition is better.
 
-The default behavior of the `preset` parameter is determined by the flag
-`use_legacy_dirichlet_bc` in the application. Change this flag to false to switch
-your application to the preferred behavior (setting `preset = true` as the default).
-
 ## Example Input Syntax
 
 !listing test/tests/bcs/matched_value_bc/matched_value_bc_test.i start=[./right_v] end=[../] include-end=true

framework/doc/content/source/bcs/FunctionDirichletBC.md

@@ -35,10 +35,6 @@ before the solve begins. With `preset = false`, the boundary condition is
 only enforced as the solve progresses. In most situations, presetting the boundary
 condition is better.
 
-The default behavior of the `preset` parameter is determined by the flag
-`use_legacy_dirichlet_bc` in the application. Change this flag to false to switch
-your application to the preferred behavior (setting `preset = true` as the default).
-
 ## Example Input Syntax
 
 !listing test/tests/bcs/function_dirichlet_bc/test.i block=BCs

framework/src/base/MooseApp.C

@@ -274,13 +274,6 @@ MooseApp::validParams()
   params.addPrivateParam<const MooseMesh *>("_master_mesh");
   params.addPrivateParam<const MooseMesh *>("_master_displaced_mesh");
 
-  params.addParam<bool>(
-      "use_legacy_dirichlet_bc",
-      true,
-      "Set false to have MOOSE utilize the new and preferred method of setting preset = true as "
-      "default for all DirichletBC and derived objects, which is ideal for the majority of solves "
-      "utilizing this boundary condition type.\nThe old behavior (which is utilized if this is set "
-      "to true) is to set preset = false as the default for DirichletBC and derived objects.");
   params.addParam<bool>(
       "use_legacy_material_output",
       true,
@@ -538,6 +531,13 @@ MooseApp::MooseApp(InputParameters parameters)
   // that need them during the setup process. Most of the restartable data isn't made available
   // until all objects have been created and all Actions have been executed (i.e. initialSetup).
   registerRestartableDataMapName(MooseApp::MESH_META_DATA, "mesh");
+
+  if (parameters.have_parameter<bool>("use_legacy_dirichlet_bc"))
+    mooseDeprecated("The parameter 'use_legacy_dirichlet_bc' is no longer valid.\n\n",
+                    "All Dirichlet boundary conditions are preset by default.\n\n",
+                    "Remove said parameter in ",
+                    name(),
+                    " to remove this deprecation warning.");
 }
 
 void

framework/src/bcs/ADDirichletBCBase.C

@@ -13,22 +13,13 @@ InputParameters
 ADDirichletBCBase::validParams()
 {
   InputParameters params = ADNodalBC::validParams();
-  params.addParam<bool>("preset",
-                        true,
-                        "Whether or not to preset the BC (apply the value before the solve "
-                        "begins). Note that the default value of this parameter is handled by the "
-                        "use_legacy_dirichlet_bc parameter on the MooseApp.");
+  params.addParam<bool>(
+      "preset", true, "Whether or not to preset the BC (apply the value before the solve begins).");
   return params;
 }
 
 ADDirichletBCBase::ADDirichletBCBase(const InputParameters & parameters)
-  : ADNodalBC(parameters),
-    // If the user sets preset, abide by it. Otherwise, pick the default depending on the
-    // application's preference to using the legacy dirichlet BC (legacy: preset = false,
-    // non-legacy: preset = true)
-    _preset(parameters.isParamSetByUser("preset")
-                ? getParam<bool>("preset")
-                : !this->_app.parameters().template get<bool>("use_legacy_dirichlet_bc"))
+  : ADNodalBC(parameters), _preset(getParam<bool>("preset"))
 {
 }