Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New libmesh interferes with MOOSE performance logging #10196

Closed
jessecarterMOOSE opened this issue Nov 1, 2017 · 4 comments
Closed

New libmesh interferes with MOOSE performance logging #10196

jessecarterMOOSE opened this issue Nov 1, 2017 · 4 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@jessecarterMOOSE
Copy link
Contributor

Rationale

Recent improvements to the libmesh performance logging (libMesh/libmesh#1462) seem to interfere with MOOSE performance logging system in a way that is not currently tested.

Description

After upgrading to newer libmesh version (later than the current submodule hash), PerformanceData Postprocessor values are all zeros except for the ACTIVE and ALIVE events, I think.

Impact

More robust testing.

Possible path forward:

  1. Add a test that checks the PerformanceData Postprocessor values of events (or just an event) other than what is currently tested. I have this ready.
  2. (Optional) Do a libmesh update to show the above test fails.

I figured doing 1. is prudent to get the test in there. Doing 2. is just my way of getting your attention 😄 However, once 1. gets merged, it's possible that libmesh CIVET tests will fail.

I'd like to get this addressed soon. It's getting in the way of my benchmarking.

tagging @permcody @roystgnr

@permcody
Copy link
Member

permcody commented Nov 2, 2017

@jessecarterMOOSE - Welcome to the forefront of MOOSE development. You are welcome to put up a PR with your new test and fix along with a libMesh submodule update. That's all the core MOOSE team does. CIVET will checkout the requested version of libmesh (usually the HEAD of master) build and run the full suite against the new hash. If it passes we can decide to merge or wait for other changes/fixes in the works. However, feel free to initiate this if you want to move forward more quickly than we do.

@permcody permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Nov 2, 2017
@jessecarterMOOSE
Copy link
Contributor Author

jessecarterMOOSE commented Nov 7, 2017

this can be closed once libmesh submodule is updated to include libMesh/libmesh#1482

@permcody
Copy link
Member

Latest libMesh merged

Note: This was never an issue with the devel branch in MOOSE. It was only present if people were running further ahead of the submodule hash.

@jessecarterMOOSE
Copy link
Contributor Author

Right you are @permcody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

2 participants