Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FaceFaceConstraint #10769

Closed
friedmud opened this issue Feb 13, 2018 · 5 comments
Closed

Rename FaceFaceConstraint #10769

friedmud opened this issue Feb 13, 2018 · 5 comments
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@friedmud
Copy link
Contributor

friedmud commented Feb 13, 2018

Rationale

FaceFaceConstraint is really a MortarConstraint so let's rename it.

Description

Name sounds more general than it is. We want to use the more general name for another object

Impact

Clearer naming

@friedmud friedmud added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Feb 13, 2018
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
friedmud added a commit to friedmud/moose that referenced this issue Feb 13, 2018
@permcody
Copy link
Member

You've opened up several tickets with really terse wording. Let's try to flesh these out a bit more, this would likely not stand up under an audit. The official requirements for these sections comes from NQA-1, but we've distilled it a bit in our PLN-4005 document in EDMS if you care to investigate what we are trying to do here.

friedmud added a commit to friedmud/moose that referenced this issue Feb 19, 2018
friedmud added a commit to friedmud/moose that referenced this issue Feb 19, 2018
friedmud added a commit to friedmud/moose that referenced this issue Feb 20, 2018
@friedmud
Copy link
Contributor Author

@permcody I added more words - I don't really know what to say. I just wanted to rename an object, I wasn't trying to be provocative here... just needed a simple ticket for renaming something. Not everything needs a large amount of prose....

@permcody
Copy link
Member

Right, I'm just pointing out that making all issues into requirements is not the right idea. Some things are just simple actions that don't require a lot thought, bookingkeeping, prose, etc. They are useful to track work, but not necessarily to generate requirements. As soon as you say, well only a subset of the issues are requirements, then an auditor want to know, which subset...

@friedmud
Copy link
Contributor Author

friedmud commented Feb 27, 2018 via email

@GiudGiud
Copy link
Contributor

Closing as addressed by #10771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

No branches or pull requests

3 participants