Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ideal gas is missing some fluid property interfaces #10964

Closed
joshuahansel opened this issue Mar 7, 2018 · 0 comments
Closed

Ideal gas is missing some fluid property interfaces #10964

joshuahansel opened this issue Mar 7, 2018 · 0 comments
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Rationale

It would be advantageous to be able to use all of the interfaces for ideal gas fluid properties.

Description

This would implement the missing interfaces in IdealGasFluidProperties. They're all implemented in StiffenedGasFluidProperties, so the task is trivial since ideal gas is a subset of stiffened gas.

Impact

More interfaces available to ideal gas.
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 7, 2018
@joshuahansel
Implemented s_from_v_e for IdealGasFluidProperties
9bb15e3 
Refs idaholab#10964
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 7, 2018
@joshuahansel
Implemented rho_from_p_s for IdealGasFluidProperties
639daa0 
Refs idaholab#10964
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 7, 2018
@joshuahansel
Implemented p_from_h_s for IdealGasFluidProperties
4d44e33 
Closes idaholab#10964
@joshuahansel joshuahansel mentioned this issue Mar 7, 2018
Merged
@permcody permcody added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules labels Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @joshuahansel