Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2-phase fluid properties object that takes 1-phase fluid properties as inputs #11641

Closed
joshuahansel opened this issue Jun 6, 2018 · 3 comments
Closed

Add 2-phase fluid properties object that takes 1-phase fluid properties as inputs #11641

joshuahansel opened this issue Jun 6, 2018 · 3 comments
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@joshuahansel
Copy link
Contributor

Rationale

It is useful to run "2-phase" problems with arbitrary combinations of 1-phase fluid properties. For example, there are cases when a 2-phase problem can be designed such that it should reduce to 2 1-phase problems acting independently.

Description

This would add a 2-phase fluid properties class that takes the names of its two 1-phase fluid properties objects. It also throws an error if a 2-phase fluid properties interface ever even gets called, to guarantee that the two phases are indeed independent.

Impact

2-phase fluid properties user objects now can take the names of their 1-phase fluid properties user objects constituents. Also, added the independent 2-phase fluid properties class.
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jun 6, 2018
@joshuahansel
Added 2-phase fluid properties object to take 1-phase fluid propertie…
da8cca8 
…s independently

Closes idaholab#11641
joshuahansel added a commit to joshuahansel/moose that referenced this issue Jun 6, 2018
@joshuahansel
Added 2-phase fluid properties object to take 1-phase fluid propertie…
3f79c57 
…s independently

Closes idaholab#11641
@permcody permcody added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules labels Jun 6, 2018
@joshuahansel
Copy link
Contributor Author

Why didn't this issue close?

@permcody
Copy link
Member

I don't think you ever made a PR and had that merged. Those commits are just on a local branch as far as I can tell.

@joshuahansel
Copy link
Contributor Author

Oh I see what happened. In addressing some changes, I rewrote a commit message and then accidentally referenced the PR number (#11642) instead of the issue number. Closing.

joshuahansel added a commit to joshuahansel/moose that referenced this issue Jun 13, 2018
@joshuahansel
Had fluid properties doc/config.yml allow test objects
3ad48a4 
Apps depending on the fluid properties module that have documentation
allowing test objects have broken documentation due to the lack of
pages for test objects in fluid properties.

Refs idaholab#11641
@joshuahansel joshuahansel mentioned this issue Jun 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@permcody @joshuahansel