New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance framework ConservativeAdvection with full upwinding option #11852
Labels
C: Framework
P: normal
A defect affecting operation with a low possibility of significantly affects.
T: task
An enhancement to the software.
Comments
permcody
added
T: task
An enhancement to the software.
P: normal
A defect affecting operation with a low possibility of significantly affects.
C: Modules
labels
Jul 12, 2018
@permcody , i had intended this was framework ConservativeAdvection, not modules |
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
Thanks |
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 13, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 16, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 16, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 16, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 16, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 17, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 17, 2018
WilkAndy
added a commit
to WilkAndy/moose
that referenced
this issue
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: Framework
P: normal
A defect affecting operation with a low possibility of significantly affects.
T: task
An enhancement to the software.
Rationale
The ConservativeAdvection Kernel is of limited use currently because it includes no numerical stabilisation. I think it's really mainly a teaching tool on how to make MOOSE Kernels but wouldn't ever be used in any real simulations because of the crazy over/under shoots that it yields. Including some stabilisation would be instructive for coders of MOOSE (they'd see nodal Values, not just normal _qp stuff) and would also allow this to be used in real simulations. I want to include a full-upwinding option: someone else can do SUPG or something else if they really want to.
Description
Make a MooseEnum that will let the user specify the upwinding type used: it defaults to "none"
For upwinding_type = none, just do what's currently in ConservativeAdvection
For upwinding_type = full, perform full upwinding. That is, look at the velocity at each node. Some nodes will have total outflow>0: evaluate the residual at these nodes based on their value of u. Other nodes will have outflow<0: they get the flow from the outflow>0 nodes.
Impact
As a teaching tool for how to do something slightly more complicated with Kernels, as well as making ConservativeAdvection more useful in real simulations.
The text was updated successfully, but these errors were encountered: