Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MooseMesh::buildPeriodicNodeMap builds an incomplete map #11891

Closed
dschwen opened this issue Jul 19, 2018 · 0 comments
Closed

MooseMesh::buildPeriodicNodeMap builds an incomplete map #11891

dschwen opened this issue Jul 19, 2018 · 0 comments
Assignees
@permcody
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Jul 19, 2018

Rationale

The periodic node map built by MooseMesh::buildPeriodicNodeMap is incomplete.

Description

In a 2D domain with a single quad4 element and x and y periodicity the node periodic node map has the following entries (master node ID : slave node ID)

 0 : 3
 0 : 1
 1 : 2
 1 : 0
 2 : 1
 3 : 0

notably absent are 3 : 2 and 2 : 3. This pattern can be observed in larger rectangular domains as well (replace node IDs 0..3 with the actual corner node IDs).

Impact

Throws a wrench into algorithm relying on getting all periodic nodes out of that map.
dschwen added a commit to dschwen/moose that referenced this issue Jul 20, 2018
@dschwen
Test broken periodic node map (idaholab#11891)
3ea705b
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Jul 23, 2018
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Refactor KDTree and add generic point list adaptor (idaholab#11891)
e5c1129
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Implement new periodic node map (idaholab#11891)
9cf5f24
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Test broken periodic node map (idaholab#11891)
35bf2d2
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Refactor KDTree and add generic point list adaptor (idaholab#11891)
02953f8
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Implement new periodic node map (idaholab#11891)
7ce0fc4
@dschwen dschwen mentioned this issue Jul 23, 2018
Merged
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Test broken periodic node map (idaholab#11891)
ab6fef2
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Refactor KDTree and add generic point list adaptor (idaholab#11891)
2057ce7
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Implement new periodic node map (idaholab#11891)
cbacbb7
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Test broken periodic node map (idaholab#11891)
a7551c0
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Refactor KDTree and add generic point list adaptor (idaholab#11891)
721e7c6
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Implement new periodic node map (idaholab#11891)
a8f1526
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Don't run periodic node map tester with recover (idaholab#11891)
4b2f383
dschwen added a commit to dschwen/moose that referenced this issue Jul 23, 2018
@dschwen
Address comments (idaholab#11891)
01eeec0
dschwen added a commit to dschwen/moose that referenced this issue Jul 24, 2018
@dschwen
Avoid race condition on restart files (idaholab#11891)
a59a25a
@dschwen dschwen mentioned this issue Jul 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@permcody permcody

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dschwen @permcody