Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test curvatures/ad_curvatures #12839

Closed
lindsayad opened this issue Feb 5, 2019 · 1 comment · Fixed by #24514
Closed

Test curvatures/ad_curvatures #12839

lindsayad opened this issue Feb 5, 2019 · 1 comment · Fixed by #24514
Assignees
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@lindsayad
Copy link
Member

Rationale

The correctness of the signs of curvatures and ad_curvatures needs to be verified.

Description

Libmesh has calculations of curvatures and now in MOOSE we have corresponding calculation of ad_curvatures. In the curvature calculation code it is noted that the sign of the curvature (e.g. the convention) is different between 2D and 3D. We really want to make this dimension agnostic, consistent with other MOOSE practices. So we need to verify that with the same set of kernels in 2D and 3D we can correctly model the effect of curvatures in things like surface tension forces.

Impact

Confidence in curvature calculations

@lindsayad lindsayad self-assigned this Feb 5, 2019
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Feb 5, 2019
lindsayad added a commit to lindsayad/moose that referenced this issue May 25, 2023
@lindsayad
Copy link
Member Author

lindsayad commented May 25, 2023

The tests added in #24204 show that a surface which curves in the opposite direction of the normal produces a positive curvature for 3D and negative curvature for 2D. We can hope that the converse is true, e.g. for a curve which curves in the same direction as the normal, we will see a positive curvature for 2D and negative curvature for 3D. This is consistent with @jwpeterson's comment in #17183 (reply in thread). In libMesh/libmesh#3560 we will make the 2D convention the convention, with the proper deprecation process. E.g. we will need a deprecation process to keep libMesh CI green after the merging of #24204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants