Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad AD support to singlephasefluidproperties #12898

Closed
rwcarlsen opened this issue Feb 11, 2019 · 1 comment
Closed

Ad AD support to singlephasefluidproperties #12898

rwcarlsen opened this issue Feb 11, 2019 · 1 comment
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@rwcarlsen
Copy link
Contributor

Rationale

Add support to fluid properties for returning AD numbers for fluid states (with all partials w.r.t. dofs filled out correctly).

Description

Users of fluid properties will then be able to maintain perfect AD-generated jacobians for materials/kernels/etc without doing this derivative nonsense themselves manually.

Impact

Add AD support - no changes to existing APIs
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Feb 11, 2019
@rwcarlsen
fluidproperties: add AD support to SinglePhase objects
ac89178 
ref idaholab#12898
@rwcarlsen rwcarlsen mentioned this issue Feb 11, 2019
Merged
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Feb 11, 2019
@rwcarlsen
fluidproperties: add AD support to SinglePhase objects
18a1234 
ref idaholab#12898
@permcody permcody added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules labels Feb 12, 2019
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Feb 13, 2019
@rwcarlsen
fluidproperties: add AD support to SinglePhase objects
b293d18 
ref idaholab#12898
This was referenced Feb 26, 2019
Closed
Merged
cpgr added a commit to cpgr/moose that referenced this issue Mar 1, 2019
@cpgr
Add documentation about AD fluid properties interface
ddba4e4 
Refs idaholab#12898
@cpgr cpgr mentioned this issue Mar 1, 2019
Merged
cpgr added a commit to cpgr/moose that referenced this issue Mar 1, 2019
@cpgr
Add documentation about AD fluid properties interface
8016cf7 
Refs idaholab#12898
@rwcarlsen
Copy link
Contributor Author

I'm going to call this resolved by #12899

rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Jul 10, 2019
@rwcarlsen
add fluid props functions that calculate derivatives as DualNumbers
87009ca 
This gives us the derivatives of fluid prop w.r.t. fluid prop contain AD
derivatives w.r.t. the dofs.  This enables better/improved pronghorn
jacobians.  Also implement derivatives for sound speed in helium.

ref idaholab#12898
rwcarlsen added a commit to rwcarlsen/moose that referenced this issue Jul 10, 2019
@rwcarlsen
add fluid props functions that calculate derivatives as DualNumbers
eb085e8 
This gives us the derivatives of fluid prop w.r.t. fluid prop contain AD
derivatives w.r.t. the dofs.  This enables better/improved pronghorn
jacobians.  Also implement derivatives for sound speed in helium.

ref idaholab#12898
@rwcarlsen rwcarlsen mentioned this issue Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwcarlsen @permcody