Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --dump and --json for AD objects #12960

Closed
dschwen opened this issue Feb 23, 2019 · 3 comments
Closed

Fix --dump and --json for AD objects #12960

dschwen opened this issue Feb 23, 2019 · 3 comments
Assignees
@aeslaughter
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Feb 23, 2019

Rationale

The --dump and --json options for MOOSE apps output two entries for each AD object, one with a <RESIDUAL> postfix and one with a <JACOBIAN> postfix. Yet neither version is accepted in the input file, only the name without a (C++ template) postfix is.

Description

Output only one copy for each AD object syntax - without the template parameter junk. That's what is expected in the input files. The template junk currently breaks auto completion and makes generated Documentation files look awkward.

Impact

Better syntax output.
@permcody permcody added C: Framework T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Feb 28, 2019
tophmatthews added a commit to tophmatthews/moose that referenced this issue Mar 28, 2019
@tophmatthews
Attempt to fix --dump and --json for AD objects (idaholab#12960)
632c581
@tophmatthews tophmatthews mentioned this issue Mar 28, 2019
Merged
tophmatthews added a commit to tophmatthews/moose that referenced this issue Mar 28, 2019
@tophmatthews
pyflakes fix (idaholab#12960)
5bb537e
tophmatthews added a commit to tophmatthews/moose that referenced this issue Mar 28, 2019
@tophmatthews
pyflakes fix (idaholab#12960)
b218d87
tophmatthews added a commit to tophmatthews/moose that referenced this issue Mar 28, 2019
@tophmatthews
removed obj_name where possible (idaholab#12960)
da594cc
tophmatthews added a commit to tophmatthews/moose that referenced this issue Mar 28, 2019
@tophmatthews
removed obj_name where possible (idaholab#12960)
2e34880
@permcody
Copy link
Member

Well this didn't work at all... Reopening...

This was re-reported by @lefebvrera today. Should be a really quick fix. I'm not sure why this previous attempt didn't work but I'm seeing brackets on all of the AD objects still.

@permcody permcody reopened this May 20, 2019
@lefebvrera
Copy link

@mbairdphys this is the issue we were discussing earlier.

aeslaughter added a commit to aeslaughter/moose that referenced this issue May 23, 2019
@aeslaughter
Remove <RESIDUAL> from --json
0f3d3f8 
(refs idaholab#12960)
aeslaughter added a commit to aeslaughter/moose that referenced this issue Sep 4, 2019
@aeslaughter
Remove <RESIDUAL> from --json
947eb47 
(refs idaholab#12960)
aeslaughter added a commit to aeslaughter/moose that referenced this issue Sep 4, 2019
@aeslaughter
Deprecate the use of <RESIDUAL> in the appsyntax extension
ea7560c 
(refs idaholab#12960)
aeslaughter added a commit to aeslaughter/moose that referenced this issue Sep 4, 2019
@aeslaughter
Deprecate the use of <RESIDUAL> in the appsyntax extension
3b89b11 
(refs idaholab#12960)
aeslaughter added a commit to aeslaughter/moose that referenced this issue Sep 6, 2019
@aeslaughter
Create comment about string copy
d38f0b4 
Co-Authored-By: Cody Permann <codypermann@gmail.com>

(refs idaholab#12960)
milljm pushed a commit that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Remove <RESIDUAL> from --json
79663f4 
(refs #12960)
milljm pushed a commit that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Deprecate the use of <RESIDUAL> in the appsyntax extension
c41de36 
(refs #12960)
milljm pushed a commit that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Create comment about string copy
278a162 
Co-Authored-By: Cody Permann <codypermann@gmail.com>

(refs #12960)
milljm pushed a commit to aeslaughter/moose that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Remove <RESIDUAL> from --json
d0b5315 
(refs idaholab#12960)
milljm pushed a commit to aeslaughter/moose that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Deprecate the use of <RESIDUAL> in the appsyntax extension
186c0b3 
(refs idaholab#12960)
milljm pushed a commit to aeslaughter/moose that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Create comment about string copy
8f689ae 
Co-Authored-By: Cody Permann <codypermann@gmail.com>

(refs idaholab#12960)
milljm pushed a commit to aeslaughter/moose that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Remove <RESIDUAL> from --json
2c89b97 
(refs idaholab#12960)
milljm pushed a commit that referenced this issue Sep 10, 2019
@aeslaughter @milljm
Remove <RESIDUAL> from --json
9d09f09 
(refs #12960)
milljm pushed a commit that referenced this issue Sep 16, 2019
@aeslaughter @milljm
Remove <RESIDUAL> from --json
f427471 
(refs #12960)
aeslaughter added a commit that referenced this issue Sep 24, 2019
@aeslaughter
Remove <RESIDUAL> from --json
0609be6 
(refs #12960)
aeslaughter added a commit that referenced this issue Sep 30, 2019
@aeslaughter
Remove <RESIDUAL> from --json
3ef1464 
(refs #12960)
milljm pushed a commit that referenced this issue Oct 16, 2019
@aeslaughter @milljm
Remove <RESIDUAL> from --json
92eafca 
(refs #12960)
@permcody
Copy link
Member

permcody commented Nov 7, 2019

closed by #13476

@permcody permcody closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeslaughter aeslaughter

Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dschwen @aeslaughter @permcody @lefebvrera