New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic method for enabling SMP for AD #13411
Comments
@idaholab/moose-team Are people OK with this or have a better idea? |
I personally think that any time a user specifies |
I kind of agree with @lindsayad. If we use NEWTON, we should trigger ``full=true" by default. But I think we also should reserve an option so that users can turn it off if they want. For example, if the equation is very simple, we do not need to form the world. |
If I remember correctly...
|
I'm with @fdkong and @lindsayad. I have been converting a bunch of stuff to AD and it is really easy to forget to set |
To be clear - |
It depends on whether you're using a line search or not. If you're using
You can definitely achieve convergence with a non-perfect Jacobian using Newton (or Quasi-newton), but you'll be pretty unlikely to achieve a quadratic convergence rate at any point in the non-linear solve.
I'm not quite sure what you mean here. |
Thanks for the replies @lindsayad. I was suggesting having an SMP input parameter as an enum with options |
Reason
When AD objects are used you need to have the following in the input file, but this isn't intuitive.
Design
I propose the following that will automatically add the correct Preconditioning if it is not provided.
Impact
This will make using MOOSE with AD easier and less prone to errors.
The text was updated successfully, but these errors were encountered: