Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coupledVectorDotDu missing for Vector Variables #13913

Closed
cticenhour opened this issue Aug 15, 2019 · 1 comment · Fixed by #13974
Closed

coupledVectorDotDu missing for Vector Variables #13913

cticenhour opened this issue Aug 15, 2019 · 1 comment · Fixed by #13974
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@cticenhour
Copy link
Member

Reason

When hand-coding Jacobians using vector variables, coupledVectorDotDu is needed. Currently, only coupledVectorDot exists. Due to ELK performing std::complex operations in several BCs, AD is not currently an option for those Jacobians (since taking the finite difference derivative w.r.t a complex variable can lead to multiple outcomes, depending on what direction in the complex plane is chosen for the derivative - thus, the AD system currently sets these derivatives equal to NaN and terminates).

Design

The design of this function should mirror that of dotDu but with vector types.

Impact

Adds new capability for cases when hand-coding a Jacobian for a vector object is still needed.
@cticenhour cticenhour added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Aug 15, 2019
@cticenhour
Copy link
Member Author

Since it's related, I plan to add coupledVectorDotDotDu to my eventual PR for this as well.

cticenhour added a commit to cticenhour/moose that referenced this issue Aug 15, 2019
@cticenhour
Add coupledVectorDotDu and coupledVectorDotDotDu
01397b0 
refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 15, 2019
@cticenhour
Modify member types and methods for dotDu and dotDotDu
7ed1b25 
Needed due to new coupledVectorDotDu and coupledVectorDotDotDu methods.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 19, 2019
@cticenhour
Add coupledVectorDotDu and coupledVectorDotDotDu
e5a00af 
refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 19, 2019
@cticenhour
Modify member types and methods for dotDu and dotDotDu
294ade6 
Needed due to new coupledVectorDotDu and coupledVectorDotDotDu methods.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 19, 2019
@cticenhour
Add coupledVectorDotDu and coupledVectorDotDotDu
a5dc27e 
refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 19, 2019
@cticenhour
Modify member types and methods for dotDu and dotDotDu
dc163da 
Needed due to new coupledVectorDotDu and coupledVectorDotDotDu methods.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 20, 2019
@cticenhour
Create templated duDotDu and duDotDotDu methods in SystemBase.
1cdbe99 
Also create new virtual methods for DisplacedSystem override and type 
helper struct in MooseTypes. 

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 21, 2019
@cticenhour
Create templated duDotDu and duDotDotDu methods in SystemBase.
8b2b00d 
Also create new virtual methods for DisplacedSystem override and type
helper struct in MooseTypes.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 21, 2019
@cticenhour
Create specialized RealVectorValue method of fetchDoFValues in MooseV…
7925f7c 
…ariableData.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Add coupledVectorDotDu and coupledVectorDotDotDu
bbf143f 
refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Modify member types and methods for dotDu and dotDotDu
b0022f3 
Needed due to new coupledVectorDotDu and coupledVectorDotDotDu methods.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Create templated duDotDu and duDotDotDu methods in SystemBase.
741e342 
Also create new virtual methods for DisplacedSystem override and type
helper struct in MooseTypes.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Create specialized RealVectorValue method of fetchDoFValues in MooseV…
be963b0 
…ariableData.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Add coupledVectorDotDu and coupledVectorDotDotDu
cb0c935 
refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Add VectorTimeKernel and VectorTimeDerivative
07c8a8e 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Add test duplicating that of ad_transient_vector_diffusion, but with …
27c7ea6 
…the new VectorTimeDerivative kernel.

Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Add VectorCoupledTimeDerivative
9f1eb10 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 26, 2019
@cticenhour
Add exodiff and Jacobian test for new VectorCoupledTimeDerivative kernel
f10f4f0 
Refs idaholab#13913
@cticenhour cticenhour mentioned this issue Aug 27, 2019
Merged
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 27, 2019
@cticenhour
Add test and test object for coupledVectorDotDotDu
68074dd 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 27, 2019
@cticenhour
Add test and test object for coupledVectorDotDotDu
4e16c83 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 27, 2019
@cticenhour
Add test and test object for coupledVectorDotDotDu
7b181e9 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 28, 2019
@cticenhour
Add test and test object for coupledVectorDotDotDu
d108c6f 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 28, 2019
@cticenhour
Add test and test object for coupledVectorDotDotDu
4540824 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Aug 28, 2019
@cticenhour
Add test and test object for coupledVectorDotDotDu
0fd21e4 
Refs idaholab#13913
cticenhour added a commit to cticenhour/moose that referenced this issue Sep 4, 2019
@cticenhour
Address comments
8b04b65 
refs idaholab#13913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementation of coupledVectorDotDu and coupledVectorDotDotDu cticenhour/moose
2 participants
@permcody @cticenhour