Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stateful + adaptivity + recover = crash #13972

Closed
cpgr opened this issue Aug 27, 2019 · 0 comments · Fixed by #13987
Closed

Stateful + adaptivity + recover = crash #13972

cpgr opened this issue Aug 27, 2019 · 0 comments · Fixed by #13987
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@cpgr
Copy link
Contributor

cpgr commented Aug 27, 2019

Bug Description

The combination of stateful material properties, adaptivity and recovering doesn't work, leading to a seg fault on recovery (possibly related to or the same issue as in #9703).

Steps to Reproduce

It looks like this combination is tested in the tests test/tests/materials/stateful_prop/stateful_prop_adaptivity_test.i and /test/tests/materials/stateful_prop/spatial_adaptivity_test.i which both currently have stateful material properties and mesh adaptivity. These tests pass with --recover.

However, these tests are set up so that there is no adaptivity in the first part of the recover test, because only one time step is taken when the --half-transient flag is used. This is misleading, as simply increasing num_steps to 4 will result in mesh adaptivity in the first half of the run, and a crash when recovering.

This is trivial to replicate. Simply set num_steps = 4 in either of these tests and run_tests --recover to see it crash while trying to load the stateful material properties.

Impact

Could be a problem for long running jobs that use both stateful materials and mesh adaptivity as no recovery is possible.

The two tests mentioned above should probably be changed so that they don't pass in recovery (and then skipped during recovery testing) as it currently looks like this combination works when in it doesn't.
@cpgr cpgr added the T: defect An anomaly, which is anything that deviates from expectations. label Aug 27, 2019
cpgr added a commit to cpgr/moose that referenced this issue Aug 29, 2019
@cpgr
Remove unused material property storage references
60d0ea2 
Refs idaholab#13972
cpgr added a commit to cpgr/moose that referenced this issue Aug 29, 2019
@cpgr
Remove stateful properties for inactive elements
5b3279b 
The stateful properties for inactive elements due to adaptivity
are not useful, so should be removed from the HashMap.

Refs idaholab#13972
cpgr added a commit to cpgr/moose that referenced this issue Aug 29, 2019
@cpgr
Update stateful and adaptivity tests and gold files
78b7a70 
These tests now properly test that stateful material
properties and mesh adaptivity can be successfully
recovered.

Closes idaholab#13972
@cpgr cpgr mentioned this issue Aug 29, 2019
Merged
cpgr added a commit to cpgr/moose that referenced this issue Aug 29, 2019
@cpgr
Implement thread safe HashMap::erase
167fd40 
Refs idaholab#13972
cpgr added a commit to cpgr/moose that referenced this issue Aug 29, 2019
@cpgr
Implement thread safe HashMap::erase
5c7fa95 
Refs idaholab#13972
@permcody permcody added C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. labels Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stateful+adaptivity+recover = working cpgr/moose
2 participants
@permcody @cpgr