Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenameBoundaryGenerator contains at least one bug and needs better test coverage #14128

Closed
permcody opened this issue Oct 3, 2019 · 0 comments · Fixed by #14354
Closed

RenameBoundaryGenerator contains at least one bug and needs better test coverage #14128

permcody opened this issue Oct 3, 2019 · 0 comments · Fixed by #14354
Labels
C: Framework Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@permcody
Copy link
Member

permcody commented Oct 3, 2019

Bug Description

Reported here with fix: https://groups.google.com/d/msgid/moose-users/6c4b6c41-53c0-4d6c-8d75-d30f29d164a9%40googlegroups.com

Steps to Reproduce

It appears that using old_boundary_name instead of old_boundary_id triggers the error.

Impact

Minor: only affects this one generator and there is a workaround by using IDs instead of names
@permcody permcody added C: Framework T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. Good first issue labels Oct 3, 2019
permcody added a commit to permcody/moose that referenced this issue Nov 11, 2019
@permcody
RenameBoundaryGenerator: bug fix and new tests
0a195fe 
closes idaholab#14128
@permcody permcody mentioned this issue Nov 11, 2019
Merged
permcody added a commit to permcody/moose that referenced this issue Nov 11, 2019
@permcody
RenameBoundaryGenerator: bug fix and new tests
2387861 
closes idaholab#14128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework Good first issue P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RenameBoundaryGenerator: bug fix and new tests permcody/moose
1 participant
@permcody