Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic for child objects of StochasticToolsTransfer #14411

Closed
aeslaughter opened this issue Nov 21, 2019 · 0 comments
Closed

Improve logic for child objects of StochasticToolsTransfer #14411

aeslaughter opened this issue Nov 21, 2019 · 0 comments
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
Stochastic Tools

Comments

@aeslaughter
Copy link
Contributor

Reason

StochasticToolsTransfer is the base class for transfers that are informed by a Sampler. The child class has duplicate logic in the constructor.

Design

The assigning of the Sampler should be in the base class.

Impact

Removal of duplicate code; no change to the API.
@aeslaughter aeslaughter added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Nov 21, 2019
@aeslaughter aeslaughter added this to To Do in Stochastic Tools via automation Nov 21, 2019
aeslaughter added a commit to aeslaughter/moose that referenced this issue Nov 25, 2019
@aeslaughter
Remove duplicate code from STM Transfer objects
272a28d 
(closes idaholab#14411)

(refs idaholab#14410)
@aeslaughter aeslaughter moved this from To Do to In progress in Stochastic Tools Nov 25, 2019
aeslaughter added a commit to aeslaughter/moose that referenced this issue Nov 26, 2019
@aeslaughter
Remove duplicate code from STM Transfer objects
c1ccce1 
(closes idaholab#14411)

(refs idaholab#14410)
aeslaughter added a commit to aeslaughter/moose that referenced this issue Nov 27, 2019
@aeslaughter
Remove duplicate code from STM Transfer objects
aad6947 
(closes idaholab#14411)

(refs idaholab#14410)
aeslaughter added a commit to aeslaughter/moose that referenced this issue Dec 2, 2019
@aeslaughter
Remove duplicate code from STM Transfer objects
2fffb9b 
(closes idaholab#14411)

(refs idaholab#14410)
@bwspenc bwspenc closed this as completed in 89e147e Dec 7, 2019
Stochastic Tools automation moved this from In progress to Done Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Modules P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
Stochastic Tools
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeslaughter @permcody