Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for sideset generators to remove the old sidesets #14460

Closed
loganharbour opened this issue Nov 29, 2019 · 0 comments · Fixed by #14463
Closed

Add option for sideset generators to remove the old sidesets #14460

loganharbour opened this issue Nov 29, 2019 · 0 comments · Fixed by #14463
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@loganharbour
Copy link
Member

Reason

The classes that derive from SideSetsGeneratorBase keep the current sideset information when adding new sideset information. There can be cases when one wants to replace the sideset information.

Design

Remove all side information for an element before adding side information. This can either be guarded with an input, or be done by default. I'm not sure which is a better choice.

Impact

Depends on if the capability is set to default or not.
@loganharbour loganharbour added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Nov 29, 2019
loganharbour added a commit to loganharbour/moose that referenced this issue Dec 2, 2019
@loganharbour
Add option to replace old sidesets
b48c745 
refs idaholab#14460
@loganharbour loganharbour mentioned this issue Dec 2, 2019
Merged
loganharbour added a commit to loganharbour/moose that referenced this issue Dec 3, 2019
@loganharbour
Add test for replacing sidesets
c4df8ad 
refs idaholab#14460
bwspenc pushed a commit to bwspenc/moose that referenced this issue Dec 7, 2019
@loganharbour @bwspenc
Add option to replace old sidesets
4e9fa66 
refs idaholab#14460
bwspenc pushed a commit to bwspenc/moose that referenced this issue Dec 7, 2019
@loganharbour @bwspenc
Add test for replacing sidesets
d98cb60 
refs idaholab#14460
bwspenc pushed a commit to bwspenc/moose that referenced this issue Dec 9, 2019
@loganharbour @bwspenc
Add option to replace old sidesets
27dc176 
refs idaholab#14460
bwspenc pushed a commit to bwspenc/moose that referenced this issue Dec 9, 2019
@loganharbour @bwspenc
Add test for replacing sidesets
402c79b 
refs idaholab#14460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to replace old sidesets loganharbour/moose
2 participants
@permcody @loganharbour