Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User defined Picard convergence check #14642

Closed
zachmprince opened this issue Jan 27, 2020 · 0 comments · Fixed by #14647
Closed

User defined Picard convergence check #14642

zachmprince opened this issue Jan 27, 2020 · 0 comments · Fixed by #14647
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@zachmprince
Copy link
Contributor

Reason

Currently, Picard iteration convergence is defined by the residual L2 norm at the end of the time-step or a custom check defined in an application's executioner. It would be useful for a user to be able to define a convergence check straight from an input file.

Design

The design could be to add another convergence check in PicardSolve that checks the value of a postprocessor given as input.

Impact

This will allow users more flexibility in defining convergence of Picard iterations.
@zachmprince zachmprince added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Jan 27, 2020
zachmprince added a commit to zachmprince/moose that referenced this issue Jan 27, 2020
@zachmprince
Adding user-defined picard convergence postprocessor in PicardSolve i…
0757e94 
…daholab#14642
@zachmprince zachmprince mentioned this issue Jan 27, 2020
Merged
zachmprince added a commit to zachmprince/moose that referenced this issue Jan 27, 2020
@zachmprince
Adding user-defined picard convergence postprocessor in PicardSolve i…
e01eb9f 
…daholab#14642
zachmprince added a commit to zachmprince/moose that referenced this issue Jan 28, 2020
@zachmprince
Adding user-defined picard convergence postprocessor in PicardSolve i…
833ac12 
…daholab#14642
zachmprince added a commit to zachmprince/moose that referenced this issue Jan 28, 2020
@zachmprince
Adding user-defined picard convergence postprocessor in PicardSolve i…
0af0569 
…daholab#14642
aeslaughter pushed a commit to aeslaughter/moose that referenced this issue Feb 13, 2020
@zachmprince @aeslaughter
Adding user-defined picard convergence postprocessor in PicardSolve i…
5099518 
…daholab#14642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom picard convergence check with postprocessor zachmprince/moose
2 participants
@permcody @zachmprince