Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtraNodesetGenerator coord parameter is confusing #14936

Closed
dschwen opened this issue Mar 20, 2020 · 0 comments · Fixed by #14945
Closed

ExtraNodesetGenerator coord parameter is confusing #14936

dschwen opened this issue Mar 20, 2020 · 0 comments · Fixed by #14945
Assignees
@dschwen
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@dschwen
Copy link
Member

dschwen commented Mar 20, 2020

Reason

ExtraNodesetGenerator has a coordinate parameter coords that is mighty confusing. In most MOOSE objects we expect coordinates to be passed in with three components. coords however expects a list of coordinates, where each point is supposed to have dim components, where dim is the mesh dimension. That means 1.0 0.0 0.0 selects the one point (1,0,0) in a 3D mesh, but the three points (1,0,0), (0,0,0) (0,0,0) in a 1D mesh.

Design

We have support for lists of lists (with the top level being semicolon separated). I suggest we disambiguate the syntax by making coords a std::vector<std::vector>> parameter. Ideally we'd make it std::vector<Point> and improve how MOOSE handles that type, but that would likely be an app breaking change.

Impact

Clearer interface
@dschwen dschwen added T: task An enhancement to the software. P: normal A defect affecting operation with a low possibility of significantly affects. labels Mar 20, 2020
@dschwen dschwen self-assigned this Mar 20, 2020
dschwen added a commit to dschwen/moose that referenced this issue Mar 20, 2020
@dschwen
Cleanup extra node set generator (idaholab#14936)
bd8395a
@dschwen dschwen mentioned this issue Mar 20, 2020
Merged
dschwen added a commit to dschwen/moose that referenced this issue Mar 21, 2020
@dschwen
Cleanup extra node set generator (idaholab#14936)
9c7b2ca
dschwen added a commit to dschwen/moose that referenced this issue Mar 21, 2020
@dschwen
Cleanup extra node set generator (idaholab#14936)
f1b37ea
dschwen added a commit to dschwen/moose that referenced this issue Mar 23, 2020
@dschwen
Cleanup extra node set generator (idaholab#14936)
72c5ec4
dschwen added a commit to dschwen/moose that referenced this issue Mar 23, 2020
@dschwen
Add multiple coord test (idaholab#14936)
cbfdde5
WilkAndy pushed a commit to WilkAndy/moose that referenced this issue Apr 19, 2020
@dschwen @WilkAndy
Cleanup extra node set generator (idaholab#14936)
810c4fb
WilkAndy pushed a commit to WilkAndy/moose that referenced this issue Apr 19, 2020
@dschwen @WilkAndy
Add multiple coord test (idaholab#14936)
8779869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dschwen dschwen

Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup extra node set generator dschwen/moose
1 participant
@dschwen