Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting appending mesh generators with actions #15121

Closed
YaqiWang opened this issue Apr 21, 2020 · 0 comments · Fixed by #15125
Closed

Supporting appending mesh generators with actions #15121

YaqiWang opened this issue Apr 21, 2020 · 0 comments · Fixed by #15125
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@YaqiWang
Copy link
Contributor

YaqiWang commented Apr 21, 2020

Reason

We have few cases where we'd like to use actions gathering some information and appending a mesh generator (modifier), for example adding a boundary surrounding a subdomain, to avoid adding it manually by users. Current mesh generator system design does not allow it.

Design

I am thinking to have a function

std::string MooseApp::getCurrentFinalMeshGenerator() const

which returns the final mesh generator by building a DependencyResolver inside the function like currently in MooseApp::executeMeshGenerators(). Then the action can use the returned name as the input for appending mesh generators. One caveat is that users must not set a final mesh generator manually in the input file. @permcody do you have any better suggestions?

Impact

New capability.

@YaqiWang YaqiWang added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Apr 21, 2020
@YaqiWang YaqiWang changed the title Supporting appending mesh generators Supporting appending mesh generators with actions Apr 22, 2020
YaqiWang added a commit to YaqiWang/moose that referenced this issue Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants