Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CPU time in Debug/show_actions and a new parameter Problem/show_initial_setup #15444

Closed
YaqiWang opened this issue Jun 10, 2020 · 0 comments · Fixed by #16298
Closed

Add CPU time in Debug/show_actions and a new parameter Problem/show_initial_setup #15444

YaqiWang opened this issue Jun 10, 2020 · 0 comments · Fixed by #16298
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.

Comments

@YaqiWang
Copy link
Contributor

Reason

It will be helpful to let Debug/show_actions=true also print the CPU time for each action. I know we have performance graph and timed screen print-out, but adding this does not hurt.

Another useful feature on performance debugging is helping understand FEProblemBase::initialSetup. I'd like to add a new parameter Problem/show_initial_setup, which will be like show_actions and print the CPU time and memory usage at each step of initial setup. This is part of my idea of having moose footprint during the run. I think having this is very useful.

Design

Enhance an existing parameter and add a new one. If you think this is valid, I can send in a PR quickly. I already had the codes and find it is very helpful for finding hot locations without using google performance tools.

Impact

New feature.
@YaqiWang YaqiWang added P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software. labels Jun 10, 2020
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 11, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
eba3c9a 
…tial setup idaholab#15444
@YaqiWang YaqiWang mentioned this issue Jun 11, 2020
Closed
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 11, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
f385eca 
…tial setup idaholab#15444
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 11, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
425fa1e 
…tial setup idaholab#15444
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 11, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
cf588be 
…tial setup idaholab#15444
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 11, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
1fcdcae 
…tial setup idaholab#15444
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 12, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
2a0a61e 
…tial setup idaholab#15444
YaqiWang added a commit to YaqiWang/moose that referenced this issue Jun 15, 2020
@YaqiWang
show wall time in actions and show memory/wall time for FEProblem ini…
e944ce6 
…tial setup idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Jun 18, 2020
@friedmud
Add memory increment to TimedPrint output refs idaholab#15444
9d0ed1f
friedmud added a commit to friedmud/moose that referenced this issue Jun 18, 2020
@friedmud
Add memory logging to perfgraph refs idaholab#15444
5247423
friedmud added a commit to friedmud/moose that referenced this issue Jun 18, 2020
@friedmud
Add memory logging to perfgraph refs idaholab#15444
f68f728
@friedmud friedmud mentioned this issue Jun 18, 2020
Closed
friedmud added a commit to friedmud/moose that referenced this issue Jun 18, 2020
@friedmud
Fix formatting refs idaholab#15444
4c33edb
friedmud added a commit to friedmud/moose that referenced this issue Jun 18, 2020
@friedmud
Remove Children columns - add self and total memory to Perfgraph refs i…
378cada 
…daholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Jun 26, 2020
@friedmud
Initial idea for print thread not working out, going to try anonther …
536f8a5 
…direction refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Jun 26, 2020
@friedmud
Perfgraph Live printing working refs idaholab#15444
d3bcab9
friedmud added a commit to friedmud/moose that referenced this issue Jun 29, 2020
@friedmud
Can now register live print names and skip printing sections without …
5bc04fb 
…it refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Jun 29, 2020
@friedmud
Move to external PerfGraphLivePrint object refs idaholab#15444
fbeb0bf
friedmud added a commit to friedmud/moose that referenced this issue Jun 29, 2020
@friedmud
Some cleanup refs idaholab#15444
75f1e89
friedmud added a commit to friedmud/moose that referenced this issue Jun 29, 2020
@friedmud
Better spacing refs idaholab#15444
042a04e
friedmud added a commit to friedmud/moose that referenced this issue Jun 30, 2020
@friedmud
Use a condition_variable to trigger quicker printing of finishing sec…
3c27278 
…tions refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Jun 30, 2020
@friedmud
Prevent overlapping output from live printing refs idaholab#15444
d67e18e
friedmud added a commit to friedmud/moose that referenced this issue Jun 30, 2020
@friedmud
WIP PerfGraphRegistry refs idaholab#15444
a5def8f
friedmud added a commit to friedmud/moose that referenced this issue Jul 1, 2020
@friedmud
Switch to external PerfGraphRegistry refs idaholab#15444
b74c2d9
friedmud added a commit to friedmud/moose that referenced this issue Jul 1, 2020
@friedmud
Updated FEProblemBase to new TIME_SECTION refs idaholab#15444
9d09cd6
friedmud added a commit to friedmud/moose that referenced this issue Jul 1, 2020
@friedmud
Remove more perfgraph registration refs idaholab#15444
8d50a2e
friedmud added a commit to friedmud/moose that referenced this issue Jul 1, 2020
@friedmud
More perfgraph registrations moving to new method idaholab#15444
8f94c94
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Almost all working refs idaholab#15444
e8f2d76 
Fixup a couple of tests refs idaholab#15444

Remove debugging statement refs idaholab#15444

Clang format idaholab#15444

Fixup build error refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Remove perfgraph unit tests refs idaholab#15444
2c8a07b
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Make sure perfgraph doesn't print during dump refs idaholab#15444
ea51616
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Initialize vars refs idaholab#15444
581e9d5 
Address comments refs idaholab#15444

Another initialization refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Remove TimedPrint refs idaholab#15444
0fa1b64 
Clang format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Fixup Modules refs idaholab#15444
be2a36b 
clang format refs idaholab#15444

Splitting for debugging refs idaholab#15444

More breaking out refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Keep timing from happening within threads refs idaholab#15444
c7d3cf5 
Undo: Testing Valgrind
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Allow LivePrint to be permanently disabled refs idaholab#15444
249f60b 
clang format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Resolve uninitialized memory issues refs idaholab#15444
24da1ef 
Fix printing error refs idaholab#15444

Clang format refs idaholab#15444

Fix compile issue refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
remove mutex refs idaholab#15444
678569a
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Fix module compilation refs idaholab#15444
e509d7c
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Make it so that the nodetoelem map can still be timed in threads refs i…
9069e09 
…daholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud @loganharbour
Remove timing from places where it shouldnt be in StochasticTools refs …
2fd7045 
…idaholab#15444

Update framework/src/utils/PerfGraphLivePrint.C

Use a const string for Finished

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

Update framework/src/utils/PerfGraphLivePrint.C

Change message to const

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

Update framework/src/utils/PerfGraph.C

Simplify

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

Removing more timers from stochastic tools refs idaholab#15444

Fixup some debugging stuff left around refs idaholab#15444

Initialize memory refs idaholab#15444

clang format refs idaholab#15444

Fix memory utils refs idaholab#15444

Update framework/src/utils/PerfGraph.C

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Better error handling in memory utils refs idaholab#15444
3ca5ad8 
clang-format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Add some asserts refs idaholab#15444
55f5e5d 
Remove unused constant refs idaholab#15444

Fix capitilization for enum refs idaholab#15444

Resolve review comments refs idaholab#15444

Fix compile errors refs idaholab#15444

Just debugging refs idaholab#15444

Reduce duplicated code refs idaholab#15444

Add debugging refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Working on thread safety refs idaholab#15444
90cc589 
Fixup memory errors refs idaholab#15444

clang format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Fix abort messages not printing refs idaholab#15444
03595c1
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Documentation update refs idaholab#15444
3c02f17
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Test PerfGraphLivePrint refs idaholab#15444
7d7265d
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Add deprecated timed prints refs idaholab#15444
40230ef 
clang format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Switch to using a vector for storing SectionInfo and allow a lockless…
6887d80 
… way for PerfGraph to read from the registry refs idaholab#15444

Clang-format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Add PerfGraphLivePrint doco refs idaholab#15444
ec29cd7
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Change how the print stack works to make it more robust, modify how t…
3e9445a 
…he PGLP is told to stop to make it more efficient refs idaholab#15444

clang format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 17, 2021
@friedmud
Change how the print stack works to make it more robust, modify how t…
c738058 
…he PGLP is told to stop to make it more efficient refs idaholab#15444

clang format refs idaholab#15444
friedmud added a commit to friedmud/moose that referenced this issue Aug 18, 2021
@friedmud
Fixup printing in TensorMechanics refs idaholab#15444
8299d89
friedmud added a commit to friedmud/moose that referenced this issue Aug 20, 2021
@friedmud
Fix threading error refs idaholab#15444
a860234
friedmud added a commit to friedmud/moose that referenced this issue Sep 2, 2021
@friedmud
Fix possible timing bug with live print and increase the default wait…
76d8da4 
… to 5 seconds refs idaholab#15444
@friedmud friedmud mentioned this issue Sep 2, 2021
Merged
friedmud added a commit to friedmud/moose that referenced this issue Sep 2, 2021
@friedmud
Fix possible timing bug with live print and increase the default wait…
89bcb75 
… to 5 seconds refs idaholab#15444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
2 participants
@YaqiWang @loganharbour