PerfGraph Live Print #16298

friedmud · 2020-11-25T03:34:23Z

Supersedes #15476

This does several things:

Removes the need to register 99% of perf sections (a couple of corner cases still need it)
Allows for recursive timed printing
All timing sections are now timed prints

To use this... you no longer need to register a section. All you do is the following:

TIME_SECTION("shortName", 4, "Doing Short Name"

The shortName will be shown in PerfGraph print tables. The 4 is the "level" (just like before). Doing Short Name is a message that will show if the time of the section, or the memory created within the section, is too high (similar to the name you would have used for TimedPrint before. That's it.

I still need to update some documentation - but I'm putting this up here to start the testing rounds on it (and get feedback).

Closes #15444

GiudGiud

quick review, have not run it.

Any reason for all the new flushes? Was this an issue?

framework/doc/content/source/utils/PerfGraph.md

framework/include/base/MooseApp.h

framework/include/outputs/ConsoleStream.h

framework/include/utils/PerfNode.h

framework/src/systems/NonlinearSystem.C

framework/src/utils/PerfGraph.C

framework/src/utils/PerfGraphLivePrint.C

stale · 2021-01-10T14:42:04Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

moosebuild · 2021-03-03T05:17:10Z

Job Documentation on 26d9748 wanted to post the following:

View the site here

This comment will be updated on new commits.

framework/include/utils/PerfGraph.h

framework/include/utils/PerfGraphLivePrint.h

framework/include/utils/PerfGraphRegistry.h

framework/src/utils/PerfGraph.C

framework/src/utils/PerfGraphLivePrint.C

andrsd

Nice cleanup 👍

framework/include/outputs/ConsoleStream.h

framework/include/base/MooseApp.h

framework/include/outputs/ConsoleStream.h

framework/include/outputs/OutputWarehouse.h

framework/src/utils/MemoryUtils.C

framework/src/utils/PerfGraph.C

framework/src/utils/PerfGraphLivePrint.C

libmesh

…daholab#15444

…idaholab#15444 Update framework/src/utils/PerfGraphLivePrint.C Use a const string for Finished Co-authored-by: Logan Harbour <loganhharbour@gmail.com> Update framework/src/utils/PerfGraphLivePrint.C Change message to const Co-authored-by: Logan Harbour <loganhharbour@gmail.com> Update framework/src/utils/PerfGraph.C Simplify Co-authored-by: Logan Harbour <loganhharbour@gmail.com> Removing more timers from stochastic tools refs idaholab#15444 Fixup some debugging stuff left around refs idaholab#15444 Initialize memory refs idaholab#15444 clang format refs idaholab#15444 Fix memory utils refs idaholab#15444 Update framework/src/utils/PerfGraph.C Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

clang-format refs idaholab#15444

Remove unused constant refs idaholab#15444 Fix capitilization for enum refs idaholab#15444 Resolve review comments refs idaholab#15444 Fix compile errors refs idaholab#15444 Just debugging refs idaholab#15444 Reduce duplicated code refs idaholab#15444 Add debugging refs idaholab#15444

Fixup memory errors refs idaholab#15444 clang format refs idaholab#15444

clang format refs idaholab#15444

… way for PerfGraph to read from the registry refs idaholab#15444 Clang-format refs idaholab#15444

…he PGLP is told to stop to make it more efficient refs idaholab#15444 clang format refs idaholab#15444

loganharbour · 2021-08-18T03:37:54Z

Slowly working through a review. I added the remainder of the tests on next + code coverage. This is a pretty big change, good to do it now

moosebuild · 2021-08-18T06:15:34Z

Job Code coverage on 26d9748 wanted to post the following:

Generated code coverage:

moose
chemical_reactions
combined
contact
external_petsc_solver
fluid_properties
fsi
functional_expansion_tools
geochemistry
heat_conduction
level_set
misc
navier_stokes
peridynamics
phase_field
porous_flow
ray_tracing
rdg
richards
stochastic_tools
tensor_mechanics
xfem

This comment will be updated on new commits.

framework/doc/content/source/utils/PerfGraph.md

framework/doc/content/source/utils/PerfGraphLivePrint.md

framework/include/outputs/OutputWarehouse.h

framework/include/utils/PerfGraph.h

framework/include/utils/PerfGraphLivePrint.h

framework/include/utils/PerfGraphRegistry.h

framework/include/utils/PerfNode.h

framework/src/problems/FEProblemBase.C

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

moosebuild · 2021-08-26T14:29:26Z

All jobs on 26d9748 : invalidated by @milljm

Invalidating all jobs as the server went down part way through

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch 2 times, most recently from e56abc6 to ed4576f Compare November 25, 2020 03:42

aeslaughter assigned friedmud Nov 25, 2020

GiudGiud reviewed Dec 11, 2020

View reviewed changes

stale bot added the stale PRs that have reached or exceeded 90 days with no activity label Jan 10, 2021

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from f746bde to 7fa31af Compare March 2, 2021 04:14

stale bot removed the stale PRs that have reached or exceeded 90 days with no activity label Mar 2, 2021

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from 7fa31af to 5e07b5f Compare March 3, 2021 02:43

loganharbour requested changes Mar 4, 2021

View reviewed changes

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch 6 times, most recently from fa5d49d to a7dd89c Compare March 18, 2021 16:10

aeslaughter added the P: normal A defect affecting operation with a low possibility of significantly affects. label Apr 12, 2021

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from 5fd5d8f to 8ca62ae Compare June 3, 2021 21:08

friedmud requested review from aeslaughter and zachmprince as code owners June 3, 2021 21:08

friedmud requested review from andrsd, fdkong and rwcarlsen as code owners June 14, 2021 17:25

andrsd reviewed Jun 15, 2021

View reviewed changes

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from cbae8ad to 19ee52f Compare June 16, 2021 21:59

moosebuild reviewed Jun 16, 2021

View reviewed changes

libmesh Outdated Show resolved Hide resolved

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from 19ee52f to 4a9d4f9 Compare June 16, 2021 22:11

moosebuild reviewed Jun 16, 2021

View reviewed changes

libmesh Outdated Show resolved Hide resolved

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from 4a9d4f9 to 7623d56 Compare June 16, 2021 22:59

friedmud and others added 14 commits August 17, 2021 16:52

remove mutex refs idaholab#15444

678569a

Fix module compilation refs idaholab#15444

e509d7c

Make it so that the nodetoelem map can still be timed in threads refs i…

9069e09

…daholab#15444

Better error handling in memory utils refs idaholab#15444

3ca5ad8

clang-format refs idaholab#15444

Working on thread safety refs idaholab#15444

90cc589

Fixup memory errors refs idaholab#15444 clang format refs idaholab#15444

Fix abort messages not printing refs idaholab#15444

03595c1

Documentation update refs idaholab#15444

3c02f17

Test PerfGraphLivePrint refs idaholab#15444

7d7265d

Add deprecated timed prints refs idaholab#15444

40230ef

clang format refs idaholab#15444

Switch to using a vector for storing SectionInfo and allow a lockless…

6887d80

… way for PerfGraph to read from the registry refs idaholab#15444 Clang-format refs idaholab#15444

Add PerfGraphLivePrint doco refs idaholab#15444

ec29cd7

Change how the print stack works to make it more robust, modify how t…

c738058

…he PGLP is told to stop to make it more efficient refs idaholab#15444 clang format refs idaholab#15444

friedmud force-pushed the perf_graph_timed_print_rebase_15444 branch from f65f140 to c738058 Compare August 17, 2021 23:49

friedmud added 2 commits August 18, 2021 10:15

Fixup printing in TensorMechanics refs idaholab#15444

8299d89

Fix threading error refs idaholab#15444

a860234

loganharbour requested changes Aug 24, 2021

View reviewed changes

Update framework/doc/content/source/utils/PerfGraphLivePrint.md

2718e9c

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

moosebuild added the PR: Failed but allowed label Aug 25, 2021

Update framework/include/outputs/OutputWarehouse.h

d35fe49

Co-authored-by: Logan Harbour <loganhharbour@gmail.com>

moosebuild removed the PR: Failed but allowed label Aug 25, 2021

friedmud added 2 commits August 25, 2021 08:07

Update framework/include/utils/PerfGraphLivePrint.h

68748a2

Update framework/src/problems/FEProblemBase.C

26d9748

moosebuild added the PR: Failed but allowed label Aug 26, 2021

loganharbour approved these changes Aug 26, 2021

View reviewed changes

friedmud merged commit c8dd435 into idaholab:next Aug 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PerfGraph Live Print #16298

PerfGraph Live Print #16298

friedmud commented Nov 25, 2020

GiudGiud left a comment

stale bot commented Jan 10, 2021

moosebuild commented Mar 3, 2021 •

edited

andrsd left a comment

loganharbour commented Aug 18, 2021

moosebuild commented Aug 18, 2021 •

edited

moosebuild commented Aug 26, 2021

PerfGraph Live Print #16298

PerfGraph Live Print #16298

Conversation

friedmud commented Nov 25, 2020

GiudGiud left a comment

Choose a reason for hiding this comment

stale bot commented Jan 10, 2021

moosebuild commented Mar 3, 2021 • edited

andrsd left a comment

Choose a reason for hiding this comment

loganharbour commented Aug 18, 2021

moosebuild commented Aug 18, 2021 • edited

moosebuild commented Aug 26, 2021

moosebuild commented Mar 3, 2021 •

edited

moosebuild commented Aug 18, 2021 •

edited